Re: [PATCH v8 08/12] NFSD: Simplify nfsd_iov_iter_aligned_bvec()

[Christoph Hellwig <hch@infradead.org>]

On Mon, Oct 27, 2025 at 11:46:26AM -0400, Chuck Lever wrote:
> +/*
> + * Check if the bvec iterator is aligned for direct I/O.
> + *
> + * bvecs generated from RPC receive buffers are contiguous: After the first
> + * bvec, all subsequent bvecs start at bv_offset zero (page-aligned).
> + * Therefore, only the first bvec is checked.
> + */
>  static bool
>  nfsd_iov_iter_aligned_bvec(const struct nfsd_file *nf, const struct iov_iter *i)
>
>
>
>  {
>  	unsigned int addr_mask = nf->nf_dio_mem_align - 1;
>  	const struct bio_vec *bvec = i->bvec;
>  
> +	return !((unsigned long)(bvec->bv_offset + i->iov_offset) & addr_mask);

Nice simplification!

But this entirely helper feels a bit pointless now vs just open coding
two lines in the caller.