From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E79422B8A6 for ; Fri, 31 Oct 2025 18:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761933713; cv=none; b=qp1UwXPxHcmXSHdPW1+iZHluozWYkXAlhUWYPqUjuTn5XeqLCtF/LzxBxlnNxoJulQyKjqFEJYo2xN6eYV/IaAE4bAHpjaZv9SqJNTulnf6aPn61D2MBdWgpQtUfQUWD9HG8S8PbtQ25eBroMGut026+Us71RNRKU2NW/koTdnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761933713; c=relaxed/simple; bh=ADSVAiPOX6B1gSmsW9EyKAj2xSrKAsl+RxaW9LESL74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lbi1js+54Axi6m/dY5WBk9UgfDUepP81eAzY5GnDCVxbhJcMJ9WiP1y/G5WtedjW8TvMxvslgqDWp8z26YS2UnEHNmh7IBEpE+iFahn4NWVUOqmfK0pdbwpLwVNJgazJNrDvkwc4juEM3LReTxhEkrNIiOKU12c1mrU2biPmJAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IBcKzo3j; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IBcKzo3j" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-475dbb524e4so15434125e9.2 for ; Fri, 31 Oct 2025 11:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761933710; x=1762538510; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E6SP8H42MhuGKhf5Tf0RkAnos12jDN/g0vG2yinKCDE=; b=IBcKzo3jcaoZoUyfz/Sju+UzRUCQBZnq2t5RP3RLAmQqAKwfErBkU/pQ2VoAIZqN7F UX8PMyghK5aB4T/KqBBF2LTWV6c05EfOMOPpMawjCSsbljL3C4bSfmYnYNj/351BTSaZ mbDi1BNPOCedAguy2uHMlrKOSZ8ix7UeDBh3MBkI8tyAQzCfyNVJPVCX5qZp5qQV/NNi /8saj0sls+3KD1KHXnTRe7kE+CNuOrTEKiSmCfgVh/NtyuiKrsbPlfcKCtnibeQNcOzb cUofYAbX6LwIGg8fBV1bFI3TR3QDE/kUA5Wmpcd4ANpe/we9AqGJaIYuqsvQuyF3JIgE hNNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761933710; x=1762538510; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E6SP8H42MhuGKhf5Tf0RkAnos12jDN/g0vG2yinKCDE=; b=E6SJpTFmeXLIGuQyofHIWcAhEhCp/FYe5BzUr6R0fsI3oLCBMOInACGM8h14KnCVQu n1rqEDIzMVa8lDmEl4uSqf+17m5Q3CeHpQ7G0tKGMY1rN2C4INsh5qGbGugJ1oSfzQaI dOxmuIp6h4zxXUayXGwiMXxjjpqshk/zfLeZrNQ/8PXjsB+yB9U84T2VZYwmrpLIq8Y2 W3ZSF7ECyFfM2BKUwITDrnCQgWozUnev3ffUDo8FI9M02bMIg4Wx+9MeqG6qg/Cf1SZ7 ekBra9FrAU7I0Yo74PxaVASC8SfQEI5yhyDhU0OPJw6zLRibN/qloFKH5/X0DysFZdsl We3w== X-Gm-Message-State: AOJu0YzNuRYvxt0Vw8DozfJDux/4z1szcfP+8CDkXGjUhEw7unv/OCPU GxT5RmMulEaKMGaLvu4eb8lTFYn8Ke4Nj0tuvUsJMFo+7LCAyEVR3vdC6OImjN21/Ts= X-Gm-Gg: ASbGncu3ClKJeWM8V8wiVZMRYdKR37dHyIv+66KwlD/zoEAvWELfBidGCs+QnZnKKCf Yo/BMXWcktSCgdQYj3RXBQ/VCXrm8i3VQenrMLQonewqANlMc//aeHrdo974SdIb03y1xhKhklz 9fT9awYKiKEp6mj77TGlWh151Vhxbl5D8inDmd/xiSewc2Jfmu694pN8lZqzNnsUzr8WEAo6yz4 mWWlxzVGj8pJErgwxmr7VsHlX7dZYIW7MbPiEpKV1b9KPCrqz5qBhiDCKiByXKb0Zo5Xg0z9Klr SWC7vGbMoYij8MQ8Xk0EElNZvOFXEVO1eWkTKTfp7R2nx3vubxMdn/DezXSFazpeCrP7OANCapY W/E+jR0TZF2acgGEhWyqN9VFF3kqrI8HuGhakYrRV0PPYgPA5nASGkGffQxHngG93PCQXcKSEVI xDGy7exA== X-Google-Smtp-Source: AGHT+IGwTAH43N3wM16XX7jUmA2M+gELhc+IjeuUzRi/sE3Q+QtcHc71PYNZcyiwhAqVZ69okNUHWA== X-Received: by 2002:a05:600c:4e09:b0:477:3012:d285 with SMTP id 5b1f17b1804b1-477307d7a25mr44275995e9.3.1761933709560; Fri, 31 Oct 2025 11:01:49 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4773c2e677csm8734835e9.3.2025.10.31.11.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 11:01:49 -0700 (PDT) Date: Fri, 31 Oct 2025 21:01:45 +0300 From: Dan Carpenter To: Bart Van Assche Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Avri Altman Subject: Re: [bvanassche:ufs-lrbp-as-priv-data 27/28] drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->clk_scaling_lock'. Message-ID: References: <202510311328.Is1wMfkq-lkp@intel.com> <5dd16de9-4594-4b42-b912-d56c3ce6868e@acm.org> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5dd16de9-4594-4b42-b912-d56c3ce6868e@acm.org> On Fri, Oct 31, 2025 at 08:57:25AM -0700, Bart Van Assche wrote: > On 10/30/25 11:06 PM, Dan Carpenter wrote: > > tree: https://github.com/bvanassche/linux ufs-lrbp-as-priv-data > > head: f5ce986a0b77ce2944bf8314554d60eec17968e8 > > commit: 226979e4eb8a5844be9fb6047a1d042bf2cd72ab [27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd() > > config: x86_64-randconfig-r071-20251031 (https://download.01.org/0day-ci/archive/20251031/202510311328.Is1wMfkq-lkp@intel.com/config) > > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202510311328.Is1wMfkq-lkp@intel.com/ > > > > New smatch warnings: > > drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->clk_scaling_lock'. > > drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->dev_cmd.lock'. > > Hi Dan, > > Thanks for the report. This report applies to a patch series from July > 10 (more than three months ago). I just pushed out the latest version of > this patch series to my github account. Can you please repeat your > analysis for https://github.com/bvanassche/linux ufs-lrbp-as-priv-data? > Hi Bart, These are from the zero day bot so how they are generated is mysterious. The zero day bot thought the patch was 3 days old. I think someone did a merge or something. I re-ran it on that branch and there were three warnings. The "literal zero" is a style issue thing so I haven't published that check. drivers/ufs/core/ufshcd.c:2955 __ufshcd_setup_cmd() warn: variable dereferenced before check 'cmd' (see line 2950) drivers/ufs/core/ufshcd.c:6849 ufshcd_err_handler() warn: inconsistent returns '&hba->host_sem'. Locked on : 6696 Unlocked on: 6688,6849 drivers/ufs/core/ufshcd.c:9035 ufshcd_device_init() info: returning a literal zero is cleaner regards, dan carpenter