From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] random: remove unused get_random_var_wait functions
Date: Sun, 2 Nov 2025 13:40:33 +0100 [thread overview]
Message-ID: <aQdRQWiOpnt_RGX0@zx2c4.com> (raw)
In-Reply-To: <20251102041941.74095-1-ebiggers@kernel.org>
On Sat, Nov 01, 2025 at 09:19:41PM -0700, Eric Biggers wrote:
> None of these functions are used, so remove them.
>
> This renders the two bugs moot:
>
> - get_random_u64_wait() used the wrong pointer type, making it provide
> only 32 bits.
>
> - The '#undef' directive used the wrong identifier, leaving the helper
> macro defined.
Applied, thanks. And nice catch.
Jason
prev parent reply other threads:[~2025-11-02 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 4:19 [PATCH] random: remove unused get_random_var_wait functions Eric Biggers
2025-11-02 12:40 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQdRQWiOpnt_RGX0@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.