From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 063B8CCFA05 for ; Mon, 3 Nov 2025 12:46:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58FB010E3CA; Mon, 3 Nov 2025 12:46:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="mPHhFvBj"; dkim-atps=neutral Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1114F10E39D for ; Mon, 3 Nov 2025 09:53:51 +0000 (UTC) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-470ff2f6e56so80855e9.0 for ; Mon, 03 Nov 2025 01:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762163629; x=1762768429; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D423dPTmNpGJKcSjJTsDfI/X/hTMvomXahsqpyIMTdY=; b=mPHhFvBj4SjDaRE1K19UZypM19UJYo7FvpcOukHCABGzfecwECiNv5PpzJdLZfgnrw 1gj9aT688EZZRPVVmPK5yixWCviMBcw+E0OqQa/PRTpfCRJXXUjFTIT7n9RWu4QW8ssX O4CczpNkLfCK9Ha528+bVqEccsKsQ6U6Dk8w9efG7NtGjfx0d5SY/JYnkgvWs0Dy1cL7 ck5Ml/qh25niKDb1GPSKUEbN20y2qW3vfmy7lsGU09MmFbEZTqZLvZ10irbEMb+YqVFK 6oC+BAKQFOIkozEJbDqh3pSTgdzwXFuhm4X3FF0J8PTPvuGFWjjtq9G8vVHZQEs1rQqO dWCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762163629; x=1762768429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D423dPTmNpGJKcSjJTsDfI/X/hTMvomXahsqpyIMTdY=; b=HACcFwf0xdCe7xEHEyVdjxQUzzlsroLnHWsIVt0tYZPSVlW3GlQqhRdIWclLZtBYIJ 7b/v2Yk9Iyk9yCGKamgZINWm+l1NHTRa8JLoPmT3qGxdwOM1bt03pUPKQHdhY9RjAi9M TwEYb7Gk6ECUeFbumKRPsofcQhMycEtfwHp0Drcm7NRbaiXUvdFl8aknzi1xyxvb01iC 5BA7YgWUl7bQ9EftNSNwDqKSBUvBvaLiqcn7iGqJx8mNXRwd52Szm6PYNkvehNosbTEJ n/HbSpUq6BRGhysqaLpnQxFP0ngJIYOtYMgd13sxCBzVglrtLXLQw8pavXu1nZk6OJeW 46SQ== X-Forwarded-Encrypted: i=1; AJvYcCWEGkCnT/aG2XCisuKSoQS/sKAGL1YvW/dvLBrdV754z0Gf0AiQZbeZydR+slPinjm8y0AYtcorNMk=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz+Oxh2FMeKmKQrGPs7sC23Dk/ABeJj8AAFah0TgvTTK350Fuix Vgns4RCcwXEM5Qnjs0s60IujU/oTMw9TIobAU0pU7Y+1U1ZZjGXMdYn3hyVeMwNw8g== X-Gm-Gg: ASbGncv4nfVWO99jZcat7niwW0AE2ENM8GbccZXu9EY062iq9cu7bab204tZ6re9/va IEMVB96YmqbrcwZvIljVvwm1dvjbOFwjYc6luUhi94JG3DNzUya/E6Z9qwlZashfnYtLvKLExRS OK9Z1rxsirR07/wwnYc06XVrf3g0VBfuofG1e/yNJjfRLVUk6SWNAcRyMeblIcEsJBE+u/nZ2+D EWcSdgbnmv1wl2QXoL2AmcIEcism2pUheDHZ5Acj4EDqbpwG8dgdekSEX8+NhKMYXpC6svwngFR WNvrLE6M8nxUOuHOXLouBSsPAbe00Af962ApHmIwFGf9wUXCmbJ7BwAzctrv77Z/ONLGJvnW/5N FdSv1hNP5D1HHTtFYvYU9XXSbrKYCONg9fBigPR204uHOmHG+vof1bpDZ0sMNVKqv7ZWT+R6ll+ XtBfyzx4D11REEHP9hOF5P4SxFIDn+GopNk9hez8bl0b3KJQ9+30LuH5JicrvV X-Google-Smtp-Source: AGHT+IGPSKpaT0Ddsg2x/WOeGEJojnpupEDLfdcNfDHxyjySRpAR+bkp9FY0Epu5UNDkS8vExhWcRA== X-Received: by 2002:a05:600c:8711:b0:45f:2940:d194 with SMTP id 5b1f17b1804b1-4773cdce892mr7221205e9.2.1762163629307; Mon, 03 Nov 2025 01:53:49 -0800 (PST) Received: from google.com (54.140.140.34.bc.googleusercontent.com. [34.140.140.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4773c374f84sm144508145e9.0.2025.11.03.01.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 01:53:48 -0800 (PST) Date: Mon, 3 Nov 2025 09:53:45 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: Alexander Gordeev , David Airlie , Alex Williamson , Ankit Agrawal , Christian Borntraeger , Brett Creeley , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Giovanni Cabiddu , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Kevin Tian , kvm@vger.kernel.org, Kirti Wankhede , linux-s390@vger.kernel.org, Longfang Liu , Matthew Rosato , Nikhil Agarwal , Nipun Gupta , Peter Oberparleiter , Halil Pasic , Pranjal Shrivastava , qat-linux@intel.com, Rodrigo Vivi , Simona Vetter , Shameer Kolothum , Sven Schnelle , Tvrtko Ursulin , virtualization@lists.linux.dev, Vineeth Vijayan , Yishai Hadas , Zhenyu Wang , Zhi Wang , patches@lists.linux.dev Subject: Re: [PATCH 09/22] vfio/platform: Provide a get_region_info op Message-ID: References: <0-v1-679a6fa27d31+209-vfio_get_region_info_op_jgg@nvidia.com> <9-v1-679a6fa27d31+209-vfio_get_region_info_op_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9-v1-679a6fa27d31+209-vfio_get_region_info_op_jgg@nvidia.com> X-Mailman-Approved-At: Mon, 03 Nov 2025 12:46:06 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Oct 23, 2025 at 08:09:23PM -0300, Jason Gunthorpe wrote: > Move it out of vfio_platform_ioctl() and re-indent it. Add it to all > platform drivers. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Mostafa Saleh Thanks, Mostafa > --- > drivers/vfio/platform/vfio_amba.c | 1 + > drivers/vfio/platform/vfio_platform.c | 1 + > drivers/vfio/platform/vfio_platform_common.c | 50 +++++++++++-------- > drivers/vfio/platform/vfio_platform_private.h | 2 + > 4 files changed, 32 insertions(+), 22 deletions(-) > > diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c > index 9f5c527baa8a36..d600deaf23b6d7 100644 > --- a/drivers/vfio/platform/vfio_amba.c > +++ b/drivers/vfio/platform/vfio_amba.c > @@ -115,6 +115,7 @@ static const struct vfio_device_ops vfio_amba_ops = { > .open_device = vfio_platform_open_device, > .close_device = vfio_platform_close_device, > .ioctl = vfio_platform_ioctl, > + .get_region_info = vfio_platform_ioctl_get_region_info, > .read = vfio_platform_read, > .write = vfio_platform_write, > .mmap = vfio_platform_mmap, > diff --git a/drivers/vfio/platform/vfio_platform.c b/drivers/vfio/platform/vfio_platform.c > index 512533501eb7f3..0e85c914b65105 100644 > --- a/drivers/vfio/platform/vfio_platform.c > +++ b/drivers/vfio/platform/vfio_platform.c > @@ -101,6 +101,7 @@ static const struct vfio_device_ops vfio_platform_ops = { > .open_device = vfio_platform_open_device, > .close_device = vfio_platform_close_device, > .ioctl = vfio_platform_ioctl, > + .get_region_info = vfio_platform_ioctl_get_region_info, > .read = vfio_platform_read, > .write = vfio_platform_write, > .mmap = vfio_platform_mmap, > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index 3bf1043cd7957c..3ebd50fb78fbb7 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -272,6 +272,34 @@ int vfio_platform_open_device(struct vfio_device *core_vdev) > } > EXPORT_SYMBOL_GPL(vfio_platform_open_device); > > +int vfio_platform_ioctl_get_region_info(struct vfio_device *core_vdev, > + struct vfio_region_info __user *arg) > +{ > + struct vfio_platform_device *vdev = > + container_of(core_vdev, struct vfio_platform_device, vdev); > + struct vfio_region_info info; > + unsigned long minsz; > + > + minsz = offsetofend(struct vfio_region_info, offset); > + > + if (copy_from_user(&info, arg, minsz)) > + return -EFAULT; > + > + if (info.argsz < minsz) > + return -EINVAL; > + > + if (info.index >= vdev->num_regions) > + return -EINVAL; > + > + /* map offset to the physical address */ > + info.offset = VFIO_PLATFORM_INDEX_TO_OFFSET(info.index); > + info.size = vdev->regions[info.index].size; > + info.flags = vdev->regions[info.index].flags; > + > + return copy_to_user(arg, &info, minsz) ? -EFAULT : 0; > +} > +EXPORT_SYMBOL_GPL(vfio_platform_ioctl_get_region_info); > + > long vfio_platform_ioctl(struct vfio_device *core_vdev, > unsigned int cmd, unsigned long arg) > { > @@ -300,28 +328,6 @@ long vfio_platform_ioctl(struct vfio_device *core_vdev, > return copy_to_user((void __user *)arg, &info, minsz) ? > -EFAULT : 0; > > - } else if (cmd == VFIO_DEVICE_GET_REGION_INFO) { > - struct vfio_region_info info; > - > - minsz = offsetofend(struct vfio_region_info, offset); > - > - if (copy_from_user(&info, (void __user *)arg, minsz)) > - return -EFAULT; > - > - if (info.argsz < minsz) > - return -EINVAL; > - > - if (info.index >= vdev->num_regions) > - return -EINVAL; > - > - /* map offset to the physical address */ > - info.offset = VFIO_PLATFORM_INDEX_TO_OFFSET(info.index); > - info.size = vdev->regions[info.index].size; > - info.flags = vdev->regions[info.index].flags; > - > - return copy_to_user((void __user *)arg, &info, minsz) ? > - -EFAULT : 0; > - > } else if (cmd == VFIO_DEVICE_GET_IRQ_INFO) { > struct vfio_irq_info info; > > diff --git a/drivers/vfio/platform/vfio_platform_private.h b/drivers/vfio/platform/vfio_platform_private.h > index 8d8fab51684909..a6008320e77bae 100644 > --- a/drivers/vfio/platform/vfio_platform_private.h > +++ b/drivers/vfio/platform/vfio_platform_private.h > @@ -85,6 +85,8 @@ int vfio_platform_open_device(struct vfio_device *core_vdev); > void vfio_platform_close_device(struct vfio_device *core_vdev); > long vfio_platform_ioctl(struct vfio_device *core_vdev, > unsigned int cmd, unsigned long arg); > +int vfio_platform_ioctl_get_region_info(struct vfio_device *core_vdev, > + struct vfio_region_info __user *arg); > ssize_t vfio_platform_read(struct vfio_device *core_vdev, > char __user *buf, size_t count, > loff_t *ppos); > -- > 2.43.0 >