From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8BF28DF07 for ; Mon, 3 Nov 2025 08:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762157651; cv=none; b=lNRZjwOjobyn5anet4x4ruU+VuO3kinxOnw1uRm+2FdDwtHxawQ/eDKp/Hv22keCeQXr/+9vOef+CY3lrY6PvQf2mheOLZlnXQAdGCB/VAumtziLa3MdzTA4pznQKvUrvOx+GMbcdygWGVoAHpYlhiYUVf9XjSYlZuyayeIHkp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762157651; c=relaxed/simple; bh=eUC7CdLY2n+Ok064KsLsxj3DXcXd7nr4SrWNiG96MhI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hgqNT8uqfurFKMhyvCM518VoKs9Vlc5M93tma1Jny4eYOj7QxkKpiX03GL3nmUumMDUhM2HHLApbChkSSP4nfFeURjNqvy8yub6/y/f4E2epQ2XJyFNWEKURf/Iw19SURGMsaUbKj5QJZ2A/30Ixp55ISXN8fD9DzbGv/Sd+LtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cTEg7NhN; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cTEg7NhN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762157650; x=1793693650; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eUC7CdLY2n+Ok064KsLsxj3DXcXd7nr4SrWNiG96MhI=; b=cTEg7NhN6ciEy+10lKUGFA8BGfIB6u8yv/7P4TOcP8MLU3bCwxipwNZp EYN0sJAY3iIBthiIDYeSsaPHdziNuH98WPNi0E4Tw5SYHV8A0HzWpxsPv an6R0UofyKgR3KvzTXfbrqEPc5T0y47QgTN5jprPaFAoct655G+GUZIc3 u2oSljv9xS2BVkglfsruKZklbIIJrraRqshGYwE2vMxgl45GeI9E4Gwoc pS3u5A3EuqgwKXn6A24xhggS1TfO0USYutNYC2+Kuzl+3SgJ2HZGnRhgP jsaGPLDwzhW88hB8zbPcqh/eZaL5bCdCzf1acieV47WJRcA7bQjMjSqeK Q==; X-CSE-ConnectionGUID: gEMnF+5xSoqe3YZZ1i0WVA== X-CSE-MsgGUID: DEx150MuTk21U4NO/JIfVw== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="68066186" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="68066186" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 00:14:10 -0800 X-CSE-ConnectionGUID: ndL/zb5NTZGkQ8kBQOxdhw== X-CSE-MsgGUID: wc3i3tJZR1O9K3nOaBqx6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,275,1754982000"; d="scan'208";a="186952919" Received: from smoehrl-linux.amr.corp.intel.com (HELO ashevche-desk.local) ([10.124.220.216]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 00:14:06 -0800 Received: from andy by ashevche-desk.local with local (Exim 4.98.2) (envelope-from ) id 1vFphP-000000055OO-0fwu; Mon, 03 Nov 2025 10:13:59 +0200 Date: Mon, 3 Nov 2025 10:13:58 +0200 From: Andy Shevchenko To: Frank Li Cc: Alexandre Belloni , Miquel Raynal , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-iio@vger.kernel.org, joshua.yeong@starfivetech.com, devicetree@vger.kernel.org, linux@roeck-us.net, Carlos Song , Adrian Fluturel Subject: Re: [PATCH v9 6/6] iio: magnetometer: Add mmc5633 sensor Message-ID: References: <20251031-i3c_ddr-v9-0-f1e523ebaf78@nxp.com> <20251031-i3c_ddr-v9-6-f1e523ebaf78@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251031-i3c_ddr-v9-6-f1e523ebaf78@nxp.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Oct 31, 2025 at 12:39:18PM -0400, Frank Li wrote: > Add mmc5633 sensor basic support. > - Support read 20 bits X/Y/Z magnetic. > - Support I3C HDR mode to send start measurememt command. > - Support I3C HDR mode to read all sensors data by one command. ... > - 1 -> ARRAY_SIZE() Maybe I missed the answer, but why are the arrays to begin with? ... > +#define MMC5633_REG_YOUT_H 0x03 > +#define MMC5633_REG_ZOUT_L 0x04 > +#define MMC5633_REG_ZOUT_H 0x05 > +#define MMC5633_REG_XOUT_2 0x06 > +#define MMC5633_REG_YOUT_2 0x07 > +#define MMC5633_REG_ZOUT_2 0x08 > +#define MMC5633_REG_TOUT 0x09 Are those _L, _H, _2 come from the datasheet? ... > +struct mmc5633_data { > + struct i3c_device *i3cdev; > + struct mutex mutex; /* protect to finish one whole measurement */ > + struct regmap *regmap; Btw, have you experimented to shuffle this to put regmap to be the first member, for example? Does it affect the binary (compiled object) size? > +}; ... > + regmap = devm_regmap_init_i2c(client, &mmc5633_regmap_config); > + if (IS_ERR(regmap)) > + return dev_err_probe(dev, PTR_ERR(regmap), "regmap init failed"); Missing trailing \n. Please, double check all messages for this. ... > + ret = regmap_attach_dev(dev, regmap, &mmc5633_regmap_config); > + if (ret) > + return ret; Why? ... > + ret = regmap_attach_dev(dev, regmap, &mmc5633_regmap_config); > + if (ret) > + return ret; Ditto. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA8F4CCF9FE for ; Mon, 3 Nov 2025 08:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gS+O4EU1KDRKoB/agyVgty1pBj6xZPqEUW7MeJEeEak=; b=yjQNK6gpKtfeQ3 WTvs221PpoyC7UbtvIkbpsDtRZ2co3LYFFhecHl2cvfvI+LuUQFWx1zEXci+uBt/xiO8a/Q9mD2QF qFhmZS91qyDDser55N5Cx8v6OAomDgFBg0wzuq1ZBsPA1FXAlkM9+QDFjWj/hKrKf78QVQPqb9D2p 6BpL7xkR++z+b3d4O9RQAxs9A92xAvhu+nvuC3id+eG8YN5w5lHFN/y9+clhz6QroHR5tJHWgiJWZ ntziLNlJv1jwFqwSpHpoAX1wOvZfzVIijAgAUL1nXAT9jQtiXHhQoknC4NLPOyKqkPcSaYx7TrCX+ wJ67qUJlCgqlqiGvo8lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFphh-00000009Ptl-1saA; Mon, 03 Nov 2025 08:14:17 +0000 Received: from mgamail.intel.com ([198.175.65.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFphe-00000009PtM-3P9B for linux-i3c@lists.infradead.org; Mon, 03 Nov 2025 08:14:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762157654; x=1793693654; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eUC7CdLY2n+Ok064KsLsxj3DXcXd7nr4SrWNiG96MhI=; b=RFKUQuvv4xWOigzyFQO/0m74O+06xrgJvzd8Xo0VCmbkwr088s6V5Yba Q52tg1SkMngSbzTzWbKoZmIioxUYjFd6SpjuEKu+j4iTmsHLSVyZoGxla MHHNRy3Zqs0DqtYKfWzmE3+0WgTylhOzjsG6x4+Jc11uBFVAKqEeaXP0N XLanKdE8rHeRojclZzI+uRrXrPS1KLkd8qSeWgpHicaCCfhfdtodFlUG9 m+rk/WgQUV9CMM4laHYkmj8+LDigeX2X2YG13XXh3Wouki10AvuaC2FZk y4/gHIA/Jv1iIy0l7P2fm1MMwlZcqEJhvT3eroG6UW4es3cw9oaNCEJ9t A==; X-CSE-ConnectionGUID: y4ylXpduSL65lqeUfOfFSg== X-CSE-MsgGUID: VqTvZq1XSW2AaYeWDUHJbA== X-IronPort-AV: E=McAfee;i="6800,10657,11601"; a="75675125" X-IronPort-AV: E=Sophos;i="6.19,275,1754982000"; d="scan'208";a="75675125" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 00:14:09 -0800 X-CSE-ConnectionGUID: ndL/zb5NTZGkQ8kBQOxdhw== X-CSE-MsgGUID: wc3i3tJZR1O9K3nOaBqx6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,275,1754982000"; d="scan'208";a="186952919" Received: from smoehrl-linux.amr.corp.intel.com (HELO ashevche-desk.local) ([10.124.220.216]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 00:14:06 -0800 Received: from andy by ashevche-desk.local with local (Exim 4.98.2) (envelope-from ) id 1vFphP-000000055OO-0fwu; Mon, 03 Nov 2025 10:13:59 +0200 Date: Mon, 3 Nov 2025 10:13:58 +0200 From: Andy Shevchenko To: Frank Li Cc: Alexandre Belloni , Miquel Raynal , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-iio@vger.kernel.org, joshua.yeong@starfivetech.com, devicetree@vger.kernel.org, linux@roeck-us.net, Carlos Song , Adrian Fluturel Subject: Re: [PATCH v9 6/6] iio: magnetometer: Add mmc5633 sensor Message-ID: References: <20251031-i3c_ddr-v9-0-f1e523ebaf78@nxp.com> <20251031-i3c_ddr-v9-6-f1e523ebaf78@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251031-i3c_ddr-v9-6-f1e523ebaf78@nxp.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251103_001414_897439_8F569122 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Fri, Oct 31, 2025 at 12:39:18PM -0400, Frank Li wrote: > Add mmc5633 sensor basic support. > - Support read 20 bits X/Y/Z magnetic. > - Support I3C HDR mode to send start measurememt command. > - Support I3C HDR mode to read all sensors data by one command. ... > - 1 -> ARRAY_SIZE() Maybe I missed the answer, but why are the arrays to begin with? ... > +#define MMC5633_REG_YOUT_H 0x03 > +#define MMC5633_REG_ZOUT_L 0x04 > +#define MMC5633_REG_ZOUT_H 0x05 > +#define MMC5633_REG_XOUT_2 0x06 > +#define MMC5633_REG_YOUT_2 0x07 > +#define MMC5633_REG_ZOUT_2 0x08 > +#define MMC5633_REG_TOUT 0x09 Are those _L, _H, _2 come from the datasheet? ... > +struct mmc5633_data { > + struct i3c_device *i3cdev; > + struct mutex mutex; /* protect to finish one whole measurement */ > + struct regmap *regmap; Btw, have you experimented to shuffle this to put regmap to be the first member, for example? Does it affect the binary (compiled object) size? > +}; ... > + regmap = devm_regmap_init_i2c(client, &mmc5633_regmap_config); > + if (IS_ERR(regmap)) > + return dev_err_probe(dev, PTR_ERR(regmap), "regmap init failed"); Missing trailing \n. Please, double check all messages for this. ... > + ret = regmap_attach_dev(dev, regmap, &mmc5633_regmap_config); > + if (ret) > + return ret; Why? ... > + ret = regmap_attach_dev(dev, regmap, &mmc5633_regmap_config); > + if (ret) > + return ret; Ditto. -- With Best Regards, Andy Shevchenko -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c