From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net-next V2 5/7] net/mlx5e: Do not re-apply TIR loopback configuration if not necessary
Date: Mon, 3 Nov 2025 13:58:44 +0000 [thread overview]
Message-ID: <aQi1FCkvCfaJtdtp@horms.kernel.org> (raw)
In-Reply-To: <1761831159-1013140-6-git-send-email-tariqt@nvidia.com>
On Thu, Oct 30, 2025 at 03:32:37PM +0200, Tariq Toukan wrote:
> On old firmware, (tis_tir_td_order=0), TIR of a transport domain should
> either be created after all SQs of the same domain, or TIR.self_lb_en
> should be reapplied using MODIFY_TIR, for self loopback filtering to
> function correctly.
>
> This is not necessary anymnore on new FW (tis_tir_td_order=1), thus
> there's no need for calling modify_tir operations after creating a new
> set of SQs to maintain the self loopback prevention functional.
>
> Skip these operations.
>
> This saves O(max_num_channels) MODIFY_TIR firmware commands in
> operations like interface up or channels configuration change.
>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-03 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 13:32 [PATCH net-next V2 0/7] net/mlx5e: Reduce interface downtime on configuration change Tariq Toukan
2025-10-30 13:32 ` [PATCH net-next V2 1/7] net/mlx5e: Enhance function structures for self loopback prevention application Tariq Toukan
2025-11-03 13:57 ` Simon Horman
2025-10-30 13:32 ` [PATCH net-next V2 2/7] net/mlx5e: Use TIR API in mlx5e_modify_tirs_lb() Tariq Toukan
2025-11-03 13:57 ` Simon Horman
2025-10-30 13:32 ` [PATCH net-next V2 3/7] net/mlx5e: Allow setting self loopback prevention bits on TIR init Tariq Toukan
2025-11-03 13:57 ` Simon Horman
2025-10-30 13:32 ` [PATCH net-next V2 4/7] net/mlx5: IPoIB, set self loopback prevention in " Tariq Toukan
2025-11-03 13:58 ` Simon Horman
2025-10-30 13:32 ` [PATCH net-next V2 5/7] net/mlx5e: Do not re-apply TIR loopback configuration if not necessary Tariq Toukan
2025-11-03 13:58 ` Simon Horman [this message]
2025-10-30 13:32 ` [PATCH net-next V2 6/7] net/mlx5e: Pass old channels as argument to mlx5e_switch_priv_channels Tariq Toukan
2025-11-03 13:59 ` Simon Horman
2025-10-30 13:32 ` [PATCH net-next V2 7/7] net/mlx5e: Defer channels closure to reduce interface down time Tariq Toukan
2025-11-03 13:59 ` Simon Horman
2025-11-05 1:20 ` [PATCH net-next V2 0/7] net/mlx5e: Reduce interface downtime on configuration change patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQi1FCkvCfaJtdtp@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.