From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FE9C2D0607 for ; Mon, 3 Nov 2025 21:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762204750; cv=none; b=GEGf6Uo3Y4T7nRQjtEHIxFRwE9btIp9PneETVLbYJzcwxHXLWhXHiyHQG/infrnlrqWTwbBEw6jzHtvHwcGe7rjPuWgtqMU5KrN2livXkcONrS3ju/aEVcP+i7HSic3JLGY4YAa63ZEig9OtMw4mWnI5X4DjEYVXyQKEZG8Pj+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762204750; c=relaxed/simple; bh=LukNrj+Lul08K2GPsc9FhbYeLRJ6Nts+ha0wN9CUmJQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=coslw1c+GSAKu5IVdJS13R+5ccNEunJF6dmN98f1mmam4b7sbegc5y/LLvSVEsnIZzKatNRHPo37Tjo4jmY1qLKb3Nqv5pcIRJd/MPd78CnPC2VjJQISSyDdO9to/OxVw2cdTRLVaAgNvocuXPuBpGKlAKO4lzPwLJYWcacQdio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=epzZBdlw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="epzZBdlw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BB39C4CEE7; Mon, 3 Nov 2025 21:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762204749; bh=LukNrj+Lul08K2GPsc9FhbYeLRJ6Nts+ha0wN9CUmJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=epzZBdlwh7/XK0wbvKOiX4mzd5IJx0wGpGoz7gow5CWqYlGd1S5tPLzH5Ypmu3Wny wkp0JYWMYs4uO2C9uvlcogICguYwVEwF9RlUfNwz6PP43JLIQpZ6gxUDrQnH8tsL0C xd0goxa8LK9RnBg0r0ft2a5fIQRr1HXx3XNauGwceSU1nEmrgH/j0rX93sqIEEpMrs RfCaI0l0imT19LVVhEgicQKXKCUskgT61yAmg4lHY5xjPsuXUx7nckpNFotmDtKZAB X8TF2UbtRZP59lzMbvAQUJlGwWYL9XUYQHyTOyGKOhSSVpvWvNyWshm7fjZvZfTpqE H6PcRt/+JGhQA== Date: Mon, 3 Nov 2025 16:19:08 -0500 From: Mike Snitzer To: Chuck Lever Cc: NeilBrown , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, Chuck Lever Subject: Re: [PATCH v9 09/12] NFSD: Combine direct I/O feasibility check with iterator setup Message-ID: References: <20251103165351.10261-1-cel@kernel.org> <20251103165351.10261-10-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251103165351.10261-10-cel@kernel.org> On Mon, Nov 03, 2025 at 11:53:48AM -0500, Chuck Lever wrote: > From: Chuck Lever > > When direct I/O is not feasible (due to missing alignment info, > too-small writes, or no alignment possible), pack the entire > write payload into a single non-DIO segment and follow the usual > direct write I/O path. > > This simplifies nfsd_direct_write() by eliminating the fallback path > and the separate nfsd_buffered_write() call - all writes now go > through nfsd_issue_write_dio() which handles both DIO and buffered > segments. > > Signed-off-by: Chuck Lever Reviewed-by: Mike Snitzer