From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8978ACCF9E3 for ; Tue, 4 Nov 2025 08:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DKF8DXpRe5ZXoRWHf+6DY2U+Qkeuzaa4vmfNWHu5yU4=; b=O++Q/8SryGh2FNpFOkZf2f8oUm jnS2Jrp1mx35R1Z84BygygXCffRwEZ5xLCx9n7WHCLAVyGmxG+DqCYR8fa4dD8rUlCR5XJoAxSiTG skEvySj6CR/Fopx5SpsR0+UCr1ZnTFE8gUzcvXUJ4ItTyYHLWoRR1I/2JOrF7kHU/EkVS6N7fdgy2 uBC//fv5AXJBzqJCtOKOvyAauwVXOLBsOudnQqHIHO9ENahJIfJmMPvv6f+/4fi1Tbn5RGxsMVqsY mEXHnQELG8uZJdeureJ4AN7vJnh3wbtyXPIxybmBybkPTpl8m1yL+fUaDLJ1TM/EiaIMaRvr4cvGJ 40CqLj9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGClr-0000000BT8u-2jui; Tue, 04 Nov 2025 08:52:07 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGClq-0000000BT8V-0xhg for linux-arm-kernel@lists.infradead.org; Tue, 04 Nov 2025 08:52:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 466AB601EF; Tue, 4 Nov 2025 08:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92586C4CEF7; Tue, 4 Nov 2025 08:52:03 +0000 (UTC) Date: Tue, 4 Nov 2025 08:52:01 +0000 From: Catalin Marinas To: Andrew Morton Cc: "David Hildenbrand (Red Hat)" , Mark Brown , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Aishwarya.TCV@arm.com Subject: Re: [PATCH] mm/huge_memory: Initialise the tags of the huge zero folio Message-ID: References: <20251031170133.280742-1-catalin.marinas@arm.com> <79a1f2dd-6752-426c-84c1-a38d300eb78c@kernel.org> <20251103170547.4935d9caae8bf558faa1b04f@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251103170547.4935d9caae8bf558faa1b04f@linux-foundation.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 03, 2025 at 05:05:47PM -0800, Andrew Morton wrote: > On Mon, 3 Nov 2025 15:59:39 +0000 Catalin Marinas wrote: > > > > --- a/arch/arm64/mm/fault.c > > > > +++ b/arch/arm64/mm/fault.c > > > > @@ -969,6 +969,16 @@ struct folio *vma_alloc_zeroed_movable_folio(struct vm_area_struct *vma, > > > > void tag_clear_highpage(struct page *page) > > > > { > > > > + /* > > > > + * Check if MTE is supported and fall back to clear_highpage(). > > > > + * get_huge_zero_folio() unconditionally passes __GFP_ZEROTAGS and > > > > + * post_alloc_hook() will invoke tag_clear_highpage(). > > > > + */ > > > > + if (!system_supports_mte()) { > > > > + clear_highpage(page); > > > > + return; > > > > + } > > > > > > LGTM! > > > > I tested it with and without MTE and it works fine. > > > > Andrew, would you like a separate patch or are you ok with folding this > > into the previous patch? > > I added it as a -fix patch thanks. > > And I added a Signed-off-by-you-by-me ;) Thanks Andrew. -- Catalin