From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH 1/4] rust/util: add ensure macro
Date: Tue, 4 Nov 2025 23:17:11 +0800 [thread overview]
Message-ID: <aQoY9zEKNPKQhV5J@intel.com> (raw)
In-Reply-To: <20251031152540.293293-2-pbonzini@redhat.com>
On Fri, Oct 31, 2025 at 04:25:36PM +0100, Paolo Bonzini wrote:
> Date: Fri, 31 Oct 2025 16:25:36 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 1/4] rust/util: add ensure macro
> X-Mailer: git-send-email 2.51.1
>
> The macro is similar to anyhow::ensure but uses QEMU's variation
> on anyhow::Error. It can be used to easily check a condition
> and format an error message.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/timer/hpet/src/device.rs | 21 ++++++----
> rust/hw/timer/hpet/src/fw_cfg.rs | 7 ++--
> rust/util/src/error.rs | 71 ++++++++++++++++++++++++++++++++
> 3 files changed, 86 insertions(+), 13 deletions(-)
Good!
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-11-04 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 15:25 [PATCH 0/4] rust: improvements to errors Paolo Bonzini
2025-10-31 15:25 ` [PATCH 1/4] rust/util: add ensure macro Paolo Bonzini
2025-11-04 15:17 ` Zhao Liu [this message]
2025-10-31 15:25 ` [PATCH 2/4] rust/util: use anyhow's native chaining capabilities Paolo Bonzini
2025-11-04 15:31 ` Zhao Liu
2025-10-31 15:25 ` [PATCH 3/4] rust/util: replace Error::err_or_unit/err_or_else with Error::with_errp Paolo Bonzini
2025-11-04 15:44 ` Zhao Liu
2025-10-31 15:25 ` [PATCH 4/4] rust: pull error_fatal out of SysbusDeviceMethods::sysbus_realize Paolo Bonzini
2025-11-04 15:47 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQoY9zEKNPKQhV5J@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.