From: Kevin Wolf <kwolf@redhat.com>
To: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH 0/2] iotests: Run iotests with sanitizers
Date: Tue, 4 Nov 2025 17:36:09 +0100 [thread overview]
Message-ID: <aQoreVO2hpaRCzt3@redhat.com> (raw)
In-Reply-To: <20251023-iotests-v1-0-fab143ca4c2f@rsg.ci.i.u-tokyo.ac.jp>
Am 23.10.2025 um 10:10 hat Akihiko Odaki geschrieben:
> Commit 2cc4d1c5eab1 ("tests/check-block: Skip iotests when sanitizers
> are enabled") changed iotests to skip when sanitizers are enabled.
> The rationale is that AddressSanitizer emits warnings and reports leaks,
> which results in test breakage. Later, sanitizers that are enabled for
> production environments (safe-stack and cfi-icall) were exempted.
>
> However, this approach has a few problems.
>
> - It requires rebuild to disable sanitizers if the existing build has
> them enabled.
> - It disables other useful non-production sanitizers.
> - The exemption of safe-stack and cfi-icall is not correctly
> implemented, so qemu-iotests are incorrectly enabled whenever either
> safe-stack or cfi-icall is enabled *and*, even if there is another
> sanitizer like AddressSanitizer.
>
> To solve these problems, direct AddressSanitizer warnings to separate
> files to avoid changing the test results, and selectively disable
> leak detection at runtime instead of requiring to disable all
> sanitizers at buildtime.
>
> Enabling AddressSanitizer actually revealed a use-after-free so a patch
> to fix it is placed before one that enables iotests with sanitizers.
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2025-11-04 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 8:10 [PATCH 0/2] iotests: Run iotests with sanitizers Akihiko Odaki
2025-10-23 8:10 ` [PATCH 1/2] qemu-img: Fix amend option parse error handling Akihiko Odaki
2025-11-13 8:29 ` Michael Tokarev
2025-11-13 8:32 ` Akihiko Odaki
2025-10-23 8:10 ` [PATCH 2/2] iotests: Run iotests with sanitizers Akihiko Odaki
2025-10-23 8:16 ` Philippe Mathieu-Daudé
2025-11-04 16:36 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQoreVO2hpaRCzt3@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.