From: David Lamparter <equinox@diac24.net>
To: David Lamparter <equinox@diac24.net>
Cc: Lorenzo Colitti <lorenzo@google.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Patrick Rohr <prohr@google.com>
Subject: Re: [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get_saddr
Date: Tue, 4 Nov 2025 22:16:43 +0100 [thread overview]
Message-ID: <aQptO3iWSdZkdfAs@eidolon.nox.tf> (raw)
In-Reply-To: <aQpmVg6iLVZiI7hH@eidolon.nox.tf>
On Tue, Nov 04, 2025 at 09:47:18PM +0100, David Lamparter wrote:
> On Tue, Nov 04, 2025 at 12:51:26PM -0500, Lorenzo Colitti wrote:
> > On Tue, Nov 4, 2025 at 9:49 AM David Lamparter <equinox@diac24.net> wrote:
> > > This adds passing the relevant flow information as well as selected
> > > nexthop into the source address selection code, to allow the RFC6724
> > > rule 5.5 code to look at its details.
> > >
> > > [...]
> > > struct ipv6_saddr_dst {
> > > - const struct in6_addr *addr;
> > > + const struct flowi6 *fl6;
> >
> > Do you need an entire flowi6? In this patch I see that you only use
> > saddr and daddr.
> [quote reordered below]
> > Similarly, do you need a sk? I don't think you use it in this patch.
> > Is it used in future patches?
>
> The answer is the same for both fields: the RFC6724 code (which I
> haven't posted yet and really should)
I've thrown up this (unfinished) code at
https://github.com/eqvinox/linux/commits/rule-5-5-HEAD/
This is NOT a request for reviews of those changes; I'm still working
on things.
next prev parent reply other threads:[~2025-11-04 21:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 14:48 [RESEND PATCH net-next v2 0/4] net/ipv6: RFC6724 rule 5.5 preparations David Lamparter
2025-11-04 14:48 ` [RESEND PATCH net-next v2 1/4] net/ipv6: flatten ip6_route_get_saddr David Lamparter
2025-11-04 17:52 ` Lorenzo Colitti
2025-11-04 14:48 ` [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get_saddr David Lamparter
2025-11-04 17:51 ` Lorenzo Colitti
2025-11-04 20:47 ` David Lamparter
2025-11-04 21:16 ` David Lamparter [this message]
2025-11-11 9:50 ` Paolo Abeni
2025-11-04 14:48 ` [RESEND PATCH net-next v2 3/4] net/ipv6: use ipv6_fl_get_saddr in output David Lamparter
2025-11-04 17:52 ` Lorenzo Colitti
2025-11-11 9:56 ` Paolo Abeni
2025-11-04 14:48 ` [RESEND PATCH net-next v2 4/4] net/ipv6: drop ip6_route_get_saddr David Lamparter
2025-11-04 17:51 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQptO3iWSdZkdfAs@eidolon.nox.tf \
--to=equinox@diac24.net \
--cc=kuba@kernel.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=prohr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.