From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E38C3CCF9E3 for ; Wed, 5 Nov 2025 03:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sd8XQMJuB4OI1OioyM6KgZgMEGhu9mj32m9cQ9oNvF8=; b=gXQZP+3R18EVXWmjV4aN1zDdyv ruWDDGTKMG9ieo8N+0nOjIWhGt/HCSvD8YYlkS/CgHFAWAQa/v2YIQbV+qj4f0h/rbYRstEPKoBt0 l8pJPykcHR4zUOgcf83bvFs1jru6i0qB8mDCb1wvzv9XnOBB9dLpP5YvbSsfTRaTSF9lEKDCgt0uQ wEY25Rurx1GonI09kZmYoRT6kzaUstNQ1ooXrLO9pN8vyA9eKOxrI6BdBAreiX+mIKv/yOrV0iOWD 3jxEXOYZwBxJ70hy+mJNNUTYr3uQ1pk/xDGSYNJSzhLE2sRWlk7qN/G4r+f1i3xwitcQhjNLbfreu YVRS/nAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGTm3-0000000Cw1w-06Is; Wed, 05 Nov 2025 03:01:27 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGTlz-0000000Cw1R-1fOS for kexec@lists.infradead.org; Wed, 05 Nov 2025 03:01:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762311679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sd8XQMJuB4OI1OioyM6KgZgMEGhu9mj32m9cQ9oNvF8=; b=KvY53i1Qk/bWa3p3tOXlXfCNX/v/4dcc7R73wPmuswEUQR3tZB4VPlkS4Zdk+nuCoRNluf 7JttPr6pELHc8gawDOJQ2w7rzWv293W38ecXVKtmlWQX5MhErLO1Ne0vARD3b7qH15HEZ7 GADdB2QfoxDZHA+Rpuad1+Rki3IQn2c= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-2hJoqEcBNlOtp5S1kBwjDg-1; Tue, 04 Nov 2025 22:01:15 -0500 X-MC-Unique: 2hJoqEcBNlOtp5S1kBwjDg-1 X-Mimecast-MFC-AGG-ID: 2hJoqEcBNlOtp5S1kBwjDg_1762311671 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 89C8119560B3; Wed, 5 Nov 2025 03:01:10 +0000 (UTC) Received: from localhost (unknown [10.72.112.190]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 53AD618004D4; Wed, 5 Nov 2025 03:01:07 +0000 (UTC) Date: Wed, 5 Nov 2025 11:01:02 +0800 From: Baoquan He To: Qiang Ma Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 3/4] kexec: print out debugging message if required for kexec_load Message-ID: References: <20251103063440.1681657-1-maqianga@uniontech.com> <20251103063440.1681657-4-maqianga@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251103063440.1681657-4-maqianga@uniontech.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251104_190123_874364_2441CDCE X-CRM114-Status: GOOD ( 22.15 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 11/03/25 at 02:34pm, Qiang Ma wrote: > The commit a85ee18c7900 ("kexec_file: print out debugging message > if required") has added general code printing in kexec_file_load(), > but not in kexec_load(). > > Especially in the RISC-V architecture, kexec_image_info() has been > removed(commit eb7622d908a0 ("kexec_file, riscv: print out debugging > message if required")). As a result, when using '-d' for the kexec_load > interface, print nothing in the kernel space. This might be helpful for > verifying the accuracy of the data passed to the kernel. Therefore, > refer to this commit a85ee18c7900 ("kexec_file: print out debugging > message if required"), debug print information has been added. > > Signed-off-by: Qiang Ma > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202510310332.6XrLe70K-lkp@intel.com/ > --- > kernel/kexec.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index c7a869d32f87..9b433b972cc1 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -154,7 +154,15 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > if (ret) > goto out; > > + kexec_dprintk("nr_segments = %lu\n", nr_segments); > for (i = 0; i < nr_segments; i++) { > + struct kexec_segment *ksegment; > + > + ksegment = &image->segment[i]; > + kexec_dprintk("segment[%lu]: buf=0x%p bufsz=0x%zx mem=0x%lx memsz=0x%zx\n", > + i, ksegment->buf, ksegment->bufsz, ksegment->mem, > + ksegment->memsz); There has already been a print_segments() in kexec-tools/kexec/kexec.c, you will get duplicated printing. That sounds not good. Have you tested this? > + > ret = kimage_load_segment(image, i); > if (ret) > goto out; > @@ -166,6 +174,9 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > if (ret) > goto out; > > + kexec_dprintk("kexec_load: type:%u, start:0x%lx head:0x%lx flags:0x%lx\n", > + image->type, image->start, image->head, flags); > + > /* Install the new kernel and uninstall the old */ > image = xchg(dest_image, image); > > -- > 2.20.1 >