From: Simon Horman <horms@kernel.org>
To: Meghana Malladi <m-malladi@ti.com>
Cc: h-mittal1@ti.com, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
danishanwar@ti.com
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix fdb hash size configuration
Date: Wed, 5 Nov 2025 10:14:12 +0000 [thread overview]
Message-ID: <aQsjdAClmmKPLHWM@horms.kernel.org> (raw)
In-Reply-To: <20251104104415.3110537-1-m-malladi@ti.com>
On Tue, Nov 04, 2025 at 04:14:15PM +0530, Meghana Malladi wrote:
> The ICSSG driver does the initial FDB configuration which
> includes setting the control registers. Other run time
> management like learning is managed by the PRU's. The default
> FDB hash size used by the firmware is 512 slots, which is
> currently missing in the current driver. Update the driver
> FDB config to include FDB hash size as well.
>
> Please refer trm [1] 6.4.14.12.17 section on how the FDB config
> register gets configured. From the table 6-1404, there is a reset
> field for FDB_HAS_SIZE which is 4, meaning 1024 slots. Currently
> the driver is not updating this reset value from 4(1024 slots) to
> 3(512 slots). This patch fixes this by updating the reset value
> to 512 slots.
>
> [1]: https://www.ti.com/lit/pdf/spruim2
> Fixes: abd5576b9c57f ("net: ti: icssg-prueth: Add support for ICSSG switch firmware")
> Signed-off-by: Meghana Malladi <m-malladi@ti.com>
> ---
>
> v2-v1:
> - Update the commit message and give more context w.r.t hardware
> for the fix as suggested by Simon Horman <horms@kernel.org>
>
> v1: https://lore.kernel.org/all/20251013085925.1391999-1-m-malladi@ti.com/
Thanks for the updated commit message, this seems much clearer to me.
Sorry for not responding to your reply to my review of v1. For some
reason I missed it until I checked the link above a few moments ago.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-05 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 10:44 [PATCH net v2] net: ti: icssg-prueth: Fix fdb hash size configuration Meghana Malladi
2025-11-05 10:14 ` Simon Horman [this message]
2025-11-06 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQsjdAClmmKPLHWM@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h-mittal1@ti.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.