From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8ED8CCFA0D for ; Thu, 6 Nov 2025 02:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bi1oZ9b9KICH6yCndcUItjcgOah5Ou2mXDzArlJhWmw=; b=BinH7NquqYhZFORnCdmS6FNUT2 uBkM+p8aywUlIZcTUDySCmnqp0EMJC1UiGdvpBOGxkZmEGdGjqSBMIJpW5TdYvSruDPs4FHvK47Ja hFMnEWrOIixfBDLYNkN5A6uApHrOHhd+hGwOfyhtmm1xAwifljDgGLrJnO5kWpDXpC8ivh3FXPkhE xF75BMjG+0z0/lZlZwlBWpe8vPgGI6/6egctB21myXKiomI+lvJSxOF5L88965pdodg8O5G9e9l63 xu3G08VOok+Uku90Pam5LkUUHkcSGiyv7BOX18KGh68Qd5EKiXU/ZRKrEOZlnTysMAXVxzlmNNTbQ 1K6wLoBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGpMC-0000000EjAr-1tni; Thu, 06 Nov 2025 02:04:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGpM9-0000000EjAQ-3u7t for kexec@lists.infradead.org; Thu, 06 Nov 2025 02:04:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762394648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bi1oZ9b9KICH6yCndcUItjcgOah5Ou2mXDzArlJhWmw=; b=LPb0dlsUGnu/0swv5KvptCz3sM8idj2bTMlIAjS7rzhUURLC2+JH+qg+kleVom1JwoAr6X 7eLH08E8GvmRwaJDbJlueL41HRuviyTxxzN6VRIXYF2EatWC+ICdBK6LyCzGqpKFTiGwst OW74eASYdhwa7azpBpK3GA+pDx5C5+E= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-fwnul_InMrG02t2eV_gtaQ-1; Wed, 05 Nov 2025 21:04:04 -0500 X-MC-Unique: fwnul_InMrG02t2eV_gtaQ-1 X-Mimecast-MFC-AGG-ID: fwnul_InMrG02t2eV_gtaQ_1762394643 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E5BDE19560A2; Thu, 6 Nov 2025 02:04:02 +0000 (UTC) Received: from localhost (unknown [10.72.112.190]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D1E81956095; Thu, 6 Nov 2025 02:04:00 +0000 (UTC) Date: Thu, 6 Nov 2025 10:03:56 +0800 From: Baoquan He To: Pingfan Liu Cc: kexec@lists.infradead.org, linux-integrity@vger.kernel.org, Andrew Morton , Mimi Zohar , Roberto Sassu , Alexander Graf , Steven Chen Subject: Re: [PATCH 2/2] kernel/kexec: Fix IMA when allocation happens in CMA area Message-ID: References: <20251105130922.13321-1-piliu@redhat.com> <20251105130922.13321-2-piliu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251105130922.13321-2-piliu@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251105_180410_044372_9FCDE9A9 X-CRM114-Status: GOOD ( 23.45 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org Hi Pingfan, On 11/05/25 at 09:09pm, Pingfan Liu wrote: > When I tested kexec with the latest kernel, I ran into the following warning: > > [ 40.712410] ------------[ cut here ]------------ > [ 40.712576] WARNING: CPU: 2 PID: 1562 at kernel/kexec_core.c:1001 kimage_map_segment+0x144/0x198 > [...] > [ 40.816047] Call trace: > [ 40.818498] kimage_map_segment+0x144/0x198 (P) > [ 40.823221] ima_kexec_post_load+0x58/0xc0 > [ 40.827246] __do_sys_kexec_file_load+0x29c/0x368 > [...] > [ 40.855423] ---[ end trace 0000000000000000 ]--- > > This is caused by the fact that kexec allocates the destination directly > in the CMA area. In that case, the CMA kernel address should be exported > directly to the IMA component, instead of using the vmalloc'd address. > > Signed-off-by: Pingfan Liu > Cc: Andrew Morton > Cc: Baoquan He > Cc: Alexander Graf > Cc: Steven Chen > Cc: linux-integrity@vger.kernel.org > To: kexec@lists.infradead.org > --- > kernel/kexec_core.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > index 9a1966207041..abe40286a02c 100644 > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -967,6 +967,7 @@ void *kimage_map_segment(struct kimage *image, int idx) > kimage_entry_t *ptr, entry; > struct page **src_pages; > unsigned int npages; > + struct page *cma; > void *vaddr = NULL; > int i; > > @@ -974,6 +975,9 @@ void *kimage_map_segment(struct kimage *image, int idx) > size = image->segment[idx].memsz; > eaddr = addr + size; > > + cma = image->segment_cma[idx]; Thanks for your fix. But I totally can't get what you are doing. The idx passed into kimage_map_segment() could index image->segment[], and can index image->segment_cma[], could you reconsider and make the code more reasonable? > + if (cma) > + return cma; > /* > * Collect the source pages and map them in a contiguous VA range. > */ > @@ -1014,7 +1018,8 @@ void *kimage_map_segment(struct kimage *image, int idx) > > void kimage_unmap_segment(void *segment_buffer) > { > - vunmap(segment_buffer); > + if (is_vmalloc_addr(segment_buffer)) > + vunmap(segment_buffer); > } > > struct kexec_load_limit { > -- > 2.49.0 >