Re: [meta-virtualization][PATCH] libvirt: Fix missing libvirt-python

[Bruce Ashfield <bruce.ashfield@gmail.com>]

In message: [meta-virtualization][PATCH] libvirt: Fix missing libvirt-python
on 05/11/2025 Tom Hochstein via lists.yoctoproject.org wrote:

> From: Tom Hochstein <tom.hochstein@oss.nxp.com>
> 
> The do_rootfs task for an image that includes libvirt-python fails.
> ```
>   - nothing provides libvirt-python needed by packagegroup-fsl-virtualization-1.0-r0.ls1012afrwy from oe-repo
> ```
> 
> The log shows that the do_compile:append() from libvirt-python.inc is
> failing but not reporting the failure.
> ```
> 174: cd: can't cd to /.../libvirt/v11.8.0+git/sources/libvirt-v11.8.0+git/libvirt-python-11.8.0
> ```
> 
> The root cause is the archive folder format is changed from
> libvirt-python-VERSION to libvirt_python-VERSION, but the do_compile
> and do_install tasks are hard-coded to the old format.

Indeed. I did change it for the main package but missed it here.

> 
> Fix the root cause by encoding the archive folder name in a common
> variable. Also, fix the build and install commands so the cd failure is
> not ignored.
> 
> Fixes: 389df3b77e

Drop this fixes line. It doesn't fix that commit, it completes
that update for the python part of libvirt.

> Signed-off-by: Tom Hochstein <tom.hochstein@oss.nxp.com>
> ---
>  recipes-extended/libvirt/libvirt-python.inc | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/recipes-extended/libvirt/libvirt-python.inc b/recipes-extended/libvirt/libvirt-python.inc
> index c430ffe5..0a99296a 100644
> --- a/recipes-extended/libvirt/libvirt-python.inc
> +++ b/recipes-extended/libvirt/libvirt-python.inc
> @@ -18,8 +18,8 @@ FILES:${PN}-python = "${bindir}/* ${libdir}/* ${libdir}/${PYTHON_DIR}/*"
>  # Currently the libvirt-python debug libraries contain buildpaths
>  INSANE_SKIP:${PN}-dbg += "buildpaths"
>  
> -SRC_URI += "http://libvirt.org/sources/python/${BPN}_python-${LIBVIRT_VERSION}.tar.gz;name=libvirt_python;subdir=${BP}"
> -
> +SRC_URI += "http://libvirt.org/sources/python/${LIBVIRT_PYTHON_ARCHIVE_NAME}.tar.gz;name=libvirt_python;subdir=${BP}"
> +LIBVIRT_PYTHON_ARCHIVE_NAME = "${BPN}_python-${LIBVIRT_VERSION}"
>  SRC_URI[libvirt_python.sha256sum] = "5d80e13e0cfb96dd254d765ee60e77e5f9b6925172540056cec0aa0e6f0ca83c"
>  
>  export LIBVIRT_API_PATH = "${S}/docs/libvirt-api.xml"
> @@ -46,8 +46,8 @@ do_compile:append() {
>  		# the syroot staged pkgconfig entries. So we clear the sysroot
>  		# for just this portion.
>  		export PKG_CONFIG_SYSROOT_DIR=
> -		cd ${UNPACKDIR}/${BP}/${BPN}-python-${LIBVIRT_VERSION} && \
> -		  ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py build
> +		cd ${UNPACKDIR}/${BP}/${LIBVIRT_PYTHON_ARCHIVE_NAME}
> +		${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py build

If the cd in it's own command fails, so should have the one in
the &&

If one is failing and the other isn't when the directory doesn't
exist, something strange is up with set -e in the routines, or
am I not seeing something that change more than the new variable
and the removal of the && ?

Bruce

>  		cd -
>  	fi
>  }
> @@ -58,9 +58,9 @@ do_install:append() {
>  		# the syroot staged pkgconfig entries. So we clear the sysroot
>  		# for just this portion.
>  		export PKG_CONFIG_SYSROOT_DIR=
> -		cd ${UNPACKDIR}/${BP}/${BPN}-python-${LIBVIRT_VERSION} && \
> -		  ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py install \
> -                       --install-lib=${D}/${PYTHON_SITEPACKAGES_DIR} ${LIBVIRT_INSTALL_ARGS}
> +		cd ${UNPACKDIR}/${BP}/${LIBVIRT_PYTHON_ARCHIVE_NAME}
> +		${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py install \
> +			--install-lib=${D}/${PYTHON_SITEPACKAGES_DIR} ${LIBVIRT_INSTALL_ARGS}
>  		cd -
>  	fi
>  }
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9426): https://lists.yoctoproject.org/g/meta-virtualization/message/9426
> Mute This Topic: https://lists.yoctoproject.org/mt/116141416/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>