Re: [PATCH v2 01/10] drm/i915/cx0: Print the correct timeout

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Nov 06, 2025 at 05:32:22PM +0200, Jani Nikula wrote:
> On Thu, 06 Nov 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_cx0_powerdown_change_sequence() uses one timeout,
> > and the pritns another one. Use the same one in both.
> 
> *prints
> 
> A bit silly considering the next one nukes the whole thing.

Yeah, I guess I could squash it and just note the discrepancy
in the commit msg.

> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_cx0_phy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> > index b3b506d0e040..21f046576ee3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> > @@ -2833,7 +2833,7 @@ void intel_cx0_powerdown_change_sequence(struct intel_encoder *encoder,
> >  				 XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US, 2, NULL))
> >  		drm_warn(display->drm,
> >  			 "PHY %c failed to bring out of Lane reset after %dus.\n",
> > -			 phy_name(phy), XELPDP_PORT_RESET_START_TIMEOUT_US);
> > +			 phy_name(phy), XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US);
> >  }
> >  
> >  void intel_cx0_setup_powerdown(struct intel_encoder *encoder)
> 
> -- 
> Jani Nikula, Intel

-- 
Ville Syrjälä
Intel