All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
	<eric.auger@redhat.com>, <peter.maydell@linaro.org>,
	<jgg@nvidia.com>, <ddutile@redhat.com>, <berrange@redhat.com>,
	<nathanc@nvidia.com>, <mochs@nvidia.com>, <smostafa@google.com>,
	<wangzhou1@hisilicon.com>, <jiangkunkun@huawei.com>,
	<jonathan.cameron@huawei.com>, <zhangfei.gao@linaro.org>,
	<zhenzhong.duan@intel.com>, <yi.l.liu@intel.com>,
	<kjaju@nvidia.com>
Subject: Re: [PATCH v6 20/33] hw/arm/smmuv3-accel: Get host SMMUv3 hw info and validate
Date: Thu, 20 Nov 2025 13:30:05 -0800	[thread overview]
Message-ID: <aR+IXfWiclEXCmLY@Asurada-Nvidia> (raw)
In-Reply-To: <aR+HuvInfdzmtRSs@Asurada-Nvidia>

On Thu, Nov 20, 2025 at 01:27:25PM -0800, Nicolin Chen wrote:
> On Thu, Nov 20, 2025 at 01:22:00PM +0000, Shameer Kolothum wrote:
> > +    /* QEMU SMMUv3 supports Range Invalidation by default */
> > +    if (FIELD_EX32(info->idr[3], IDR3, RIL) !=
> > +                FIELD_EX32(s->idr[3], IDR3, RIL)) {
> > +        error_setg(errp, "Host SMMUv3 doesn't support Range Invalidation");
> > +        return false;
> 
> If host reports info->ril=1 while VM sets s->ril=0, it could have
> worked. But this would reject the case.
> 
> I think it should be:
>     if (FIELD_EX32(info->idr[3], IDR3, RIL) <
>         FIELD_EX32(s->idr[3], IDR3, RIL)) {
> ?

Never mind. I realized that you are doing in a followup patch :)

Nicolin


  reply	other threads:[~2025-11-20 21:31 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 13:21 [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3 Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 01/33] backends/iommufd: Introduce iommufd_backend_alloc_viommu Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 02/33] backends/iommufd: Introduce iommufd_backend_alloc_vdev Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 03/33] hw/arm/smmu-common: Factor out common helper functions and export Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 04/33] hw/arm/smmu-common: Make iommu ops part of SMMUState Shameer Kolothum
2025-12-11 11:03   ` Cédric Le Goater
2025-11-20 13:21 ` [PATCH v6 05/33] hw/arm/smmuv3-accel: Introduce smmuv3 accel device Shameer Kolothum
2025-12-11 12:54   ` Cédric Le Goater
2025-12-12  5:48     ` Shameer Kolothum
2025-12-17 17:38       ` Cédric Le Goater
2025-12-17 18:38         ` Shameer Kolothum
2026-01-06 10:22         ` Eric Auger
2026-01-07 15:28           ` Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 06/33] hw/arm/smmuv3-accel: Initialize shared system address space Shameer Kolothum
2025-12-08 17:05   ` Eric Auger
2025-11-20 13:21 ` [PATCH v6 07/33] hw/pci/pci: Move pci_init_bus_master() after adding device to bus Shameer Kolothum
2025-11-20 20:44   ` Nicolin Chen
2025-11-20 13:21 ` [PATCH v6 08/33] hw/pci/pci: Add optional supports_address_space() callback Shameer Kolothum
2025-11-20 20:51   ` Nicolin Chen
2025-11-21 10:38     ` Shameer Kolothum
2025-11-21 17:28       ` Nicolin Chen
2025-11-21 17:32         ` Shameer Kolothum
2025-12-11 14:40   ` Cédric Le Goater
2025-12-12  5:54     ` Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 09/33] hw/pci-bridge/pci_expander_bridge: Move TYPE_PXB_PCIE_DEV to header Shameer Kolothum
2025-11-20 20:52   ` Nicolin Chen
2025-11-20 13:21 ` [PATCH v6 10/33] hw/arm/smmuv3-accel: Restrict accelerated SMMUv3 to vfio-pci endpoints with iommufd Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 11/33] hw/arm/smmuv3: Implement get_viommu_cap() callback Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 12/33] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback Shameer Kolothum
2025-12-09  7:57   ` Eric Auger
2025-12-11 13:41   ` Cédric Le Goater
2025-11-20 13:21 ` [PATCH v6 13/33] hw/arm/smmuv3: propagate smmuv3_cmdq_consume() errors to caller Shameer Kolothum
2025-11-20 20:59   ` Nicolin Chen
2025-12-04 16:28   ` Eric Auger
2025-11-20 13:21 ` [PATCH v6 14/33] hw/arm/smmuv3-accel: Add nested vSTE install/uninstall support Shameer Kolothum
2025-12-09  8:14   ` Eric Auger
2025-11-20 13:21 ` [PATCH v6 15/33] hw/arm/smmuv3-accel: Install SMMUv3 GBPA based hwpt Shameer Kolothum
2025-11-20 21:03   ` Nicolin Chen
2025-11-20 13:21 ` [PATCH v6 16/33] hw/pci/pci: Introduce a callback to retrieve the MSI doorbell GPA directly Shameer Kolothum
2025-11-20 21:05   ` Nicolin Chen
2025-12-04 16:38   ` Eric Auger
2025-12-04 18:57     ` Shameer Kolothum
2025-12-08 17:03       ` Eric Auger
2025-11-20 13:21 ` [PATCH v6 17/33] hw/arm/smmuv3: Add support for providing a direct MSI doorbell GPA Shameer Kolothum
2025-11-20 21:21   ` Nicolin Chen
2025-11-21  9:57     ` Shameer Kolothum
2025-11-21 17:56       ` Nicolin Chen
2025-11-24  8:05         ` Shameer Kolothum
2025-11-24 18:34           ` Nicolin Chen
2025-11-24 19:01             ` Shameer Kolothum
2025-11-24 20:08               ` Nicolin Chen
2025-12-11 14:03   ` Cédric Le Goater via
2025-12-11 14:03     ` Cédric Le Goater
2025-12-30 12:22     ` Shameer Kolothum
2026-01-06 11:06     ` Eric Auger
2025-11-20 13:21 ` [PATCH v6 18/33] hw/arm/smmuv3-accel: Add support to issue invalidation cmd to host Shameer Kolothum
2025-11-20 13:21 ` [PATCH v6 19/33] hw/arm/smmuv3: Initialize ID registers early during realize() Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 20/33] hw/arm/smmuv3-accel: Get host SMMUv3 hw info and validate Shameer Kolothum
2025-11-20 21:27   ` Nicolin Chen
2025-11-20 21:30     ` Nicolin Chen [this message]
2025-11-20 13:22 ` [PATCH v6 21/33] hw/pci-host/gpex: Allow to generate preserve boot config DSM #5 Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 22/33] hw/arm/virt: Set PCI preserve_config for accel SMMUv3 Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 23/33] tests/qtest/bios-tables-test: Prepare for IORT revison upgrade Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 24/33] hw/arm/virt-acpi-build: Add IORT RMR regions to handle MSI nested binding Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 25/33] tests/qtest/bios-tables-test: Update IORT blobs after revision upgrade Shameer Kolothum
2025-11-20 13:22 ` [PATCH v6 26/33] hw/arm/smmuv3: Add accel property for SMMUv3 device Shameer Kolothum
2025-12-11 15:11   ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 27/33] hw/arm/smmuv3-accel: Add a property to specify RIL support Shameer Kolothum
2025-11-20 21:34   ` Nicolin Chen via
2025-11-20 21:34     ` Nicolin Chen via
2025-11-21 10:04     ` Shameer Kolothum
2025-12-11 15:14   ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 28/33] hw/arm/smmuv3-accel: Add support for ATS Shameer Kolothum
2025-11-20 21:40   ` Nicolin Chen
2025-11-24 12:00   ` Zhangfei Gao
2025-11-24 12:48     ` Shameer Kolothum
2025-12-08 17:36   ` Eric Auger
2025-11-20 13:22 ` [PATCH v6 29/33] hw/arm/smmuv3-accel: Add property to specify OAS bits Shameer Kolothum
2025-11-20 21:47   ` Nicolin Chen
2025-12-08 17:17     ` Eric Auger
2025-12-11 15:23   ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 30/33] backends/iommufd: Retrieve PASID width from iommufd_backend_get_device_info() Shameer Kolothum
2025-11-20 21:50   ` Nicolin Chen
2025-12-11 15:24   ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 31/33] Extend get_cap() callback to support PASID Shameer Kolothum
2025-11-20 21:56   ` Nicolin Chen
2025-12-08 17:20   ` Eric Auger
2025-12-11 15:26   ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 32/33] vfio: Synthesize vPASID capability to VM Shameer Kolothum
2025-11-20 21:59   ` Nicolin Chen
2025-12-09  9:51   ` Eric Auger
2025-12-09 11:17     ` Yi Liu
2026-01-05 16:33       ` Shameer Kolothum
2026-01-06 10:54         ` Eric Auger
2026-01-06 11:38           ` Shameer Kolothum
2026-01-06 13:22             ` Eric Auger
2026-01-06 17:00               ` Alex Williamson
2025-12-15 10:54   ` Cédric Le Goater
2026-01-02 15:35     ` Shameer Kolothum
2026-01-09  9:32       ` Cédric Le Goater
2025-11-20 13:22 ` [PATCH v6 33/33] hw/arm/smmuv3-accel: Add support for PASID enable Shameer Kolothum
2025-11-20 22:09   ` Nicolin Chen
2025-11-21 10:22     ` Shameer Kolothum
2025-11-21 17:50       ` Nicolin Chen
2025-11-21 18:36         ` Nicolin Chen
2025-11-21 18:44         ` Jason Gunthorpe
2025-11-24  8:17         ` Shameer Kolothum
2025-11-20 17:06 ` [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3 Nicolin Chen
2025-11-24 12:09   ` Zhangfei Gao
2025-12-08 10:08 ` Duan, Zhenzhong
2025-12-08 11:15   ` Shameer Kolothum
2025-12-09  2:30     ` Duan, Zhenzhong
2025-12-09  3:33       ` Yi Liu
2025-12-09 10:31 ` Cédric Le Goater
2025-12-10 15:07   ` Shameer Kolothum
2025-12-10 16:07     ` Cédric Le Goater
2025-12-10 16:18       ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR+IXfWiclEXCmLY@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=berrange@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=jiangkunkun@huawei.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kjaju@nvidia.com \
    --cc=mochs@nvidia.com \
    --cc=nathanc@nvidia.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=skolothumtho@nvidia.com \
    --cc=smostafa@google.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=yi.l.liu@intel.com \
    --cc=zhangfei.gao@linaro.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.