Re: [PATCH nf-next 3/3] netfilter: nft_set_rbtree: do not modifiy live tree

[Florian Westphal <fw@strlen.de>]

kernel test robot <lkp@intel.com> wrote:
> sparse warnings: (new ones prefixed by >>)
> >> net/netfilter/nft_set_rbtree.c:893:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
>    net/netfilter/nft_set_rbtree.c:893:9: sparse:    struct rb_node [noderef] __rcu *
>    net/netfilter/nft_set_rbtree.c:893:9: sparse:    struct rb_node *
>    net/netfilter/nft_set_rbtree.c: note: in included file (through include/linux/mm_types.h, include/linux/page-flags.h, arch/arm64/include/asm/mte.h, ...):
>    include/linux/rbtree.h:74:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
>    include/linux/rbtree.h:74:9: sparse:    struct rb_node [noderef] __rcu *
>    include/linux/rbtree.h:74:9: sparse:    struct rb_node *

Sigh.

>  > 893		rcu_assign_pointer(priv->root[genbit].rb_node, NULL);

This can be replaced by

WRITE_ONCE(priv->root[genbit].rb_node, NULL);