All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Artur Stupa <arthur.stupa@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix block comment style issues
Date: Wed, 19 Nov 2025 14:36:48 +0300	[thread overview]
Message-ID: <aR2r0A_fBj_w9JgZ@stanley.mountain> (raw)
In-Reply-To: <20251119062701.38279-1-arthur.stupa@gmail.com>

On Tue, Nov 18, 2025 at 10:26:40PM -0800, Artur Stupa wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 027b2dd0a4b9..a5234fdbf984 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -133,8 +133,8 @@ u8 *rtw_set_ie(u8 *pbuf,
>  }
>  
>  /*----------------------------------------------------------------------------
> -index: the information element id index, limit is the limit for search
> ------------------------------------------------------------------------------*/
> + * index: the information element id index, limit is the limit for search
> + *--------------------------------------------------------------------------*/

We generally don't like these "****************" or "-----------------" lines.

[ snip ]

> @@ -1691,12 +1691,11 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len)
>  		/* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */
>  
>  /*
> -
> -	for (i = 0; i<9; i++)
> -	{
> -			pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> -	}
> -*/
> + * for (i = 0; i<9; i++)
> + * {
> + *	pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]);
> + * }
> + */

Delete dead code.  Don't reformat it.

regards,
dan carpenter


  reply	other threads:[~2025-11-19 11:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  6:26 [PATCH] staging: rtl8723bs: core: fix block comment style issues Artur Stupa
2025-11-19 11:36 ` Dan Carpenter [this message]
2025-11-20  0:29 ` [PATCH v2] " Artur Stupa
2025-11-20  7:22   ` Dan Carpenter
2025-11-20 20:30   ` [PATCH v3 1/2] " Artur Stupa
2025-11-20 20:30     ` [PATCH v3 2/2] staging: rtl8723bs: core: delete commented-out code Artur Stupa
2025-11-21  6:59     ` [PATCH v3 1/2] staging: rtl8723bs: core: fix block comment style issues Greg KH
2025-11-21 22:41     ` [PATCH v4 " Artur Stupa
2025-11-21 22:41       ` [PATCH v4 2/2] staging: rtl8723bs: core: delete commented-out code Artur Stupa
2025-11-24  7:58       ` [PATCH v4 1/2] staging: rtl8723bs: core: fix block comment style issues Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR2r0A_fBj_w9JgZ@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=arthur.stupa@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.