From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E9552FD690 for ; Wed, 19 Nov 2025 16:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570989; cv=none; b=i1m8IHHoEIpVp0UjiIpMj8XNE6qGoujO/9f1Ej9t+aKhKp2q5Wr54CkSd7vPmrGLgkZ0J4tgYSDvz8ROykmKp7MYhp66pZeVt3sZ6Dcq94NYz7WRvQTvLV4+CFjMh+xZLPsrhhhNkke+zbQMOFFs9jtkGz3YzS9bChXZ8+tfQrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570989; c=relaxed/simple; bh=qbbAxyMgmBlg1AAKbJOUCpUgPPi8Btz2Ln7CeoD83oE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dJZdjknFXqKvVgKvV8aATkVnSQ8WTbpc8eTCzy42iC1qGpLl/eYamLo+llUAWnhlCweg9OcqajpGQSSI14ZdOOjsXXB5ZT1ZIhTaKIIUhnCORPLi9e63BqJKvnqowD2HIC6jrS/0wow2Xu1h/fLbt8iHhNQajev2BFDUY9H1MkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=O8FdUhyp; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="O8FdUhyp" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-64175dfc338so12735555a12.0 for ; Wed, 19 Nov 2025 08:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763570984; x=1764175784; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bYw4lES0fnG+I/ctcpXXA4ELSSPoXmPDvxOLmmyea9M=; b=O8FdUhypzgXkXYpgF19NlL2TfenH6anQkLcfrllrLa8rbU7R+aCclWpT8IpsGULwJ/ hMRgir+KK9oMKR4zcYBJ1nhS4M4sP7sYBzHrpVUC5pWvqOc0KmrIDWQESgiG9RqaCTmv 8osm53+BOQvmtbaC7P1rqLiekdeEEgiLK7O7aiIYgYhvOFS1y5tIUp1/ntA2bkZKZmgx 2UM6I9BE3ziUoKxtmrSTbXpCB5e1S4mAnjAMqlCrhXInjlIUNOgwGnwVff1UedyzVoai 1OunF7ujuqTjTTznV8CG+OPfyjk4hOl2yFeq4jDRhlszHQwsbetrNdysPr9pPstaWhWV 1LhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763570984; x=1764175784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bYw4lES0fnG+I/ctcpXXA4ELSSPoXmPDvxOLmmyea9M=; b=IzC3db+neHy6Y8vtAnpmZXwaQ1whRpepOuOuFig+83VC5XX7glF48Zemdm8+2pnmZY 1zjofh3p2BR4dZM9hi4z2b4UxLoMlO4ZDcp9VkCZZW3WD4kYDBcKEjE1DxowDiI9EnVD XfXJecRE+mafGLeqksjpO4F7gmRqN916zkzDYRnoDJ5wpy4RtChGZOfynLUtHhY66aI7 4YRS6tDX/jYAtvNdMhdJYFSv+kNU2JoyC117qhPWCgNvBCQup4wbaVxhHU48/u6m54Vo XWJiJeLqDilaRMkN89FvEOzBIa4y5rujBOrG0V/9qHFh4O9UOb2PEReAvPFb0hJH9QO4 F0CA== X-Gm-Message-State: AOJu0YwrwK64anACM5OJ7sKox9iGs3n9R8pmErW1hNrBIajseNLCpL1Q K6XKUwMBwUIyrriGZLnlhp0COLgiZR9is4ECBygEcmiTCjR6+YmqEK7HdEEg50G9vc0= X-Gm-Gg: ASbGncs5ybwUvssMiSoly5KZKkq7hOZwhGBtZ4qhlc+erbr9Irk8NAqU9E9+2goxfKq 1rvyDajxVxkqEzDi7VDSuyM8lRml+MCTTCa+y7eJvIAgBZ8boJdSrYywBp8WUjrfhpHVQXD4yMO w9pEjXvWmLRcFTu21UzV32V1XQG6TqdL/KtPZ9vG19UjUYlvMAnWLfFHpDdVC+BrNe1OQE+yAdp obNh2lPD6kcBvkx4qgRpvArwkUf8cLRiy2eWkWSSmA6TP4fh8kZlrDP0SSSP+uLlpzRGTWtLd80 JI+kvNLF0+1j1P9CqDx9EkSlX0FWNmEoigMwtwfUIMAhUDqwd0EwHbOf/CnSo7l0EzsfHdBtY89 GIFFI54z+8nsEkqYG/3vguNpHqrXYBG9MJUCtZMRalpefYjR5zQnXWJv9aFem/qZzP/Om18Siqp MutCuOHCz6gQD9Wg== X-Google-Smtp-Source: AGHT+IFDoROGZgruPQJ7m3AcMb3zSLys4xD/Jw+BcTvy7ckgfi/HxP6CgQkmAX0990vC8a1UVHKaRw== X-Received: by 2002:a05:6402:2355:b0:643:ab7:2e86 with SMTP id 4fb4d7f45d1cf-645363c8600mr10267a12.13.1763570984489; Wed, 19 Nov 2025 08:49:44 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6453633fe28sm28855a12.0.2025.11.19.08.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 08:49:44 -0800 (PST) Date: Wed, 19 Nov 2025 17:49:42 +0100 From: Petr Mladek To: Chris Down Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , Steven Rostedt , John Ogness , Geert Uytterhoeven , Tony Lindgren , kernel-team@fb.com Subject: Re: [PATCH v7 03/13] printk: console: Implement core per-console loglevel infrastructure Message-ID: References: <201aa88f5c476ba56aa23183d74643275f8b2b41.1763492585.git.chris@chrisdown.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201aa88f5c476ba56aa23183d74643275f8b2b41.1763492585.git.chris@chrisdown.name> On Wed 2025-11-19 03:07:06, Chris Down wrote: > This commit adds the internal infrastructure to support per-console > log levels, which will be configurable through sysfs and the kernel > command line in future commits. > > --- a/include/linux/console.h > +++ b/include/linux/console.h > @@ -518,11 +521,6 @@ extern struct hlist_head console_list; > static inline short console_srcu_read_flags(const struct console *con) > { > WARN_ON_ONCE(!console_srcu_read_lock_is_held()); > - > - /* > - * The READ_ONCE() matches the WRITE_ONCE() when @flags are modified > - * for registered consoles with console_srcu_write_flags(). > - */ > return data_race(READ_ONCE(con->flags)); > } As you have already pointed out, the above change looks unintentional. > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -3835,8 +3967,12 @@ static int try_enable_preferred_console(struct console *newcon, > * without matching. Accept the pre-enabled consoles only when match() > * and setup() had a chance to be called. > */ > - if (newcon->flags & CON_ENABLED && c->user_specified == user_specified) > + if (newcon->flags & CON_ENABLED && c->user_specified == user_specified) { > + /* Ensure level is initialized for pre-enabled consoles */ > + if (newcon->level == 0) > + newcon->level = LOGLEVEL_DEFAULT; This change does not harm. But it seems to be redundant after all. The same check/set is done also in register_console(), see below. > return 0; > + } > > return -ENOENT; > } > @@ -4039,6 +4175,14 @@ void register_console(struct console *newcon) > } > > newcon->dropped = 0; > + > + /* > + * Don't unconditionally overwrite, it may have been set on the command > + * line already. > + */ > + if (newcon->level == 0) > + newcon->level = LOGLEVEL_DEFAULT; > + > init_seq = get_init_console_seq(newcon, bootcon_registered); > > if (newcon->flags & CON_NBCON) { Otherwise, it looks good to me. With two hunks removed, feel free to use: Reviewed-by: Petr Mladek Best Regards, Petr