From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Alexander Dahl <ada@thorsis.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: phy: adin1100: Fix software power-down ready condition
Date: Wed, 19 Nov 2025 13:21:50 +0000 [thread overview]
Message-ID: <aR3Ebs6gdra4qGzo@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251119124737.280939-2-ada@thorsis.com>
On Wed, Nov 19, 2025 at 01:47:36PM +0100, Alexander Dahl wrote:
> Value CRSM_SFT_PD written to Software Power-Down Control Register
> (CRSM_SFT_PD_CNTRL) is 0x01 and therefor different to value
> CRSM_SFT_PD_RDY (0x02) read from System Status Register (CRSM_STAT) for
> confirmation powerdown has been reached.
>
> The condition could have only worked when disabling powerdown
> (both 0x00), but never when enabling it (0x01 != 0x02).
>
> Result is a timeout, like so:
>
> $ ifdown eth0
> macb f802c000.ethernet eth0: Link is Down
> ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110
> ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110
>
> Fixes: 7eaf9132996a ("net: phy: adin1100: Add initial support for ADIN1100 industrial PHY")
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-19 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 12:47 [PATCH 0/2] net: phy: adin1100: Fix powerdown mode setting Alexander Dahl
2025-11-19 12:47 ` [PATCH 1/2] net: phy: adin1100: Fix software power-down ready condition Alexander Dahl
2025-11-19 13:21 ` Russell King (Oracle) [this message]
2025-11-19 12:47 ` [PATCH 2/2] net: phy: adin1100: Simplify register value passing Alexander Dahl
2025-11-19 13:20 ` Russell King (Oracle)
2025-11-19 13:22 ` Russell King (Oracle)
2025-11-19 15:11 ` [PATCH 0/2] net: phy: adin1100: Fix powerdown mode setting Nuno Sá
2025-11-21 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR3Ebs6gdra4qGzo@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ada@thorsis.com \
--cc=alexandru.ardelean@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.