From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com,
gengdongjiu1@gmail.com, peter.maydell@linaro.org,
alistair@alistair23.me, edgar.iglesias@gmail.com,
npiggin@gmail.com, harshpb@linux.ibm.com, palmer@dabbelt.com,
liwei1518@gmail.com, dbarboza@ventanamicro.com,
zhiwei_liu@linux.alibaba.com, sstabellini@kernel.org,
anthony@xenproject.org, paul@xen.org, berrange@redhat.com,
farosas@suse.de, eblake@redhat.com, vsementsov@yandex-team.ru,
eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, zhao1.liu@intel.com,
qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/5] hw/nvram/xlnx-bbram: More idiomatic and simpler error reporting
Date: Wed, 19 Nov 2025 13:09:24 -0500 [thread overview]
Message-ID: <aR4H1FyafbvOUw2c@x1.local> (raw)
In-Reply-To: <20251119130855.105479-3-armbru@redhat.com>
On Wed, Nov 19, 2025 at 02:08:52PM +0100, Markus Armbruster wrote:
> bbram_bdrv_error() interpolates a "detail" string into a template with
> error_setg_errno(), then reports the result with error_report().
> Produces error messages with an unwanted '.':
>
> BLK-NAME: BBRAM backstore DETAIL failed.: STERROR
>
> Replace both calls of bbram_bdrv_error() by straightforward
> error_report(), and drop the function. This is less code, easier to
> read, and the error message is more greppable.
>
> Also delete the unwanted '.'.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2025-11-19 18:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:08 [PATCH 0/5] A bit of cleanup around Error Markus Armbruster
2025-11-19 13:08 ` [PATCH 1/5] hw/core/loader: Make load_elf_hdr() return bool, simplify caller Markus Armbruster
2025-11-19 15:37 ` Richard Henderson
2025-11-19 16:34 ` Vladimir Sementsov-Ogievskiy
2025-11-19 19:12 ` Markus Armbruster
2025-11-20 10:51 ` Philippe Mathieu-Daudé
2025-11-19 18:06 ` Peter Xu
2025-11-20 12:04 ` Daniel Henrique Barboza
2025-11-20 12:55 ` BALATON Zoltan
2025-11-20 19:12 ` Markus Armbruster
2025-11-20 14:53 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 2/5] hw/nvram/xlnx-bbram: More idiomatic and simpler error reporting Markus Armbruster
2025-11-19 16:39 ` Vladimir Sementsov-Ogievskiy
2025-11-19 19:10 ` Markus Armbruster
2025-11-19 18:09 ` Peter Xu [this message]
2025-11-20 8:10 ` Luc Michel
2025-11-20 14:54 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 3/5] nbd/client-connection: Replace error_propagate() by assignment Markus Armbruster
2025-11-19 16:43 ` Vladimir Sementsov-Ogievskiy
2025-11-19 18:09 ` Peter Xu
2025-11-20 14:55 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 4/5] error: error_free(NULL) is safe, drop unnecessary conditionals Markus Armbruster
2025-11-19 15:38 ` Richard Henderson
2025-11-19 16:44 ` Vladimir Sementsov-Ogievskiy
2025-11-19 18:04 ` Peter Xu
2025-11-20 14:56 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 5/5] error: Consistently name Error * objects err, and not errp Markus Armbruster
2025-11-19 13:22 ` Andrew Cooper
2025-11-19 13:35 ` Daniel P. Berrangé
2025-11-19 13:48 ` Markus Armbruster
2025-11-20 14:57 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR4H1FyafbvOUw2c@x1.local \
--to=peterx@redhat.com \
--cc=alistair@alistair23.me \
--cc=anisinha@redhat.com \
--cc=anthony@xenproject.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=gengdongjiu1@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=liwei1518@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.