From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Yang Li <yang.lee@linux.alibaba.com>,
James Clark <james.clark@linaro.org>,
Thomas Falcon <thomas.falcon@intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH v5 1/3] perf stat: Read tool events last
Date: Wed, 19 Nov 2025 10:12:45 -0800 [thread overview]
Message-ID: <aR4IneHUTlFuyRhe@google.com> (raw)
In-Reply-To: <20251118211326.1840989-2-irogers@google.com>
On Tue, Nov 18, 2025 at 01:13:24PM -0800, Ian Rogers wrote:
> When reading a metric like memory bandwidth on multiple sockets, the
> additional sockets will be on CPUS > 0. Because of the affinity
> reading, the counters are read on CPU 0 along with the time, then the
> later sockets are read. This can lead to the later sockets having a
> bandwidth larger than is possible for the period of time. To avoid
> this move the reading of tool events to occur after all other events
> are read.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Applied this one to perf-tools-next first, thanks!
Best regards,
Namhyung
next prev parent reply other threads:[~2025-11-19 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 21:13 [PATCH v5 0/3] perf stat affinity changes Ian Rogers
2025-11-18 21:13 ` [PATCH v5 1/3] perf stat: Read tool events last Ian Rogers
2025-11-19 18:12 ` Namhyung Kim [this message]
2025-11-18 21:13 ` [PATCH v5 2/3] perf evlist: Reduce affinity use and move into iterator, fix no affinity Ian Rogers
2025-11-18 21:13 ` [PATCH v5 3/3] perf stat: Add no-affinity flag Ian Rogers
2025-11-18 23:19 ` Andi Kleen
2025-11-19 0:58 ` Ian Rogers
2025-11-19 15:37 ` Andi Kleen
2025-11-19 16:25 ` Ian Rogers
2026-01-02 15:26 ` [PATCH v5 0/3] perf stat affinity changes Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR4IneHUTlFuyRhe@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.