From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: tom.hochstein@oss.nxp.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH v3] libvirt: Fix missing libvirt-python
Date: Wed, 19 Nov 2025 18:23:40 -0500 [thread overview]
Message-ID: <aR5RfHEVSHzA0kaX@gmail.com> (raw)
In-Reply-To: <20251106161130.1562976-1-tom.hochstein@oss.nxp.com>
Sorry for the delay, I've been really focused on some larger container
stack runtime issues that have been consuming all my time.
I've merged this to master-next.
Bruce
In message: [meta-virtualization][PATCH v3] libvirt: Fix missing libvirt-python
on 06/11/2025 Tom Hochstein via lists.yoctoproject.org wrote:
> From: Tom Hochstein <tom.hochstein@oss.nxp.com>
>
> The do_rootfs task for an image that includes libvirt-python fails.
> ```
> - nothing provides libvirt-python needed by packagegroup-fsl-virtualization-1.0-r0.ls1012afrwy from oe-repo
> ```
>
> The log shows that the do_compile:append() from libvirt-python.inc is
> failing but not reporting the failure.
> ```
> 174: cd: can't cd to /.../libvirt/v11.8.0+git/sources/libvirt-v11.8.0+git/libvirt-python-11.8.0
> ```
>
> The root cause is the archive folder format is changed from
> libvirt-python-VERSION to libvirt_python-VERSION, but the do_compile
> and do_install tasks are hard-coded to the old format.
>
> Fix the root cause by encoding the archive folder name in a common
> variable. Also, fix the build and install commands so the cd failure is
> not ignored.
>
> Signed-off-by: Tom Hochstein <tom.hochstein@oss.nxp.com>
> ---
> recipes-extended/libvirt/libvirt-python.inc | 22 ++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/recipes-extended/libvirt/libvirt-python.inc b/recipes-extended/libvirt/libvirt-python.inc
> index c430ffe5..b8c8656b 100644
> --- a/recipes-extended/libvirt/libvirt-python.inc
> +++ b/recipes-extended/libvirt/libvirt-python.inc
> @@ -18,8 +18,8 @@ FILES:${PN}-python = "${bindir}/* ${libdir}/* ${libdir}/${PYTHON_DIR}/*"
> # Currently the libvirt-python debug libraries contain buildpaths
> INSANE_SKIP:${PN}-dbg += "buildpaths"
>
> -SRC_URI += "http://libvirt.org/sources/python/${BPN}_python-${LIBVIRT_VERSION}.tar.gz;name=libvirt_python;subdir=${BP}"
> -
> +SRC_URI += "http://libvirt.org/sources/python/${LIBVIRT_PYTHON_ARCHIVE_NAME}.tar.gz;name=libvirt_python;subdir=${BP}"
> +LIBVIRT_PYTHON_ARCHIVE_NAME = "${BPN}_python-${LIBVIRT_VERSION}"
> SRC_URI[libvirt_python.sha256sum] = "5d80e13e0cfb96dd254d765ee60e77e5f9b6925172540056cec0aa0e6f0ca83c"
>
> export LIBVIRT_API_PATH = "${S}/docs/libvirt-api.xml"
> @@ -46,8 +46,12 @@ do_compile:append() {
> # the syroot staged pkgconfig entries. So we clear the sysroot
> # for just this portion.
> export PKG_CONFIG_SYSROOT_DIR=
> - cd ${UNPACKDIR}/${BP}/${BPN}-python-${LIBVIRT_VERSION} && \
> - ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py build
> + src=${UNPACKDIR}/${BP}/${LIBVIRT_PYTHON_ARCHIVE_NAME}
> + if [ ! -d $src ]; then
> + bbfatal "Python source not found at expected location \"$src\". Please check that this task logic and SRC_URI are consistent."
> + fi
> + cd $src
> + ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py build
> cd -
> fi
> }
> @@ -58,9 +62,13 @@ do_install:append() {
> # the syroot staged pkgconfig entries. So we clear the sysroot
> # for just this portion.
> export PKG_CONFIG_SYSROOT_DIR=
> - cd ${UNPACKDIR}/${BP}/${BPN}-python-${LIBVIRT_VERSION} && \
> - ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py install \
> - --install-lib=${D}/${PYTHON_SITEPACKAGES_DIR} ${LIBVIRT_INSTALL_ARGS}
> + src=${UNPACKDIR}/${BP}/${LIBVIRT_PYTHON_ARCHIVE_NAME}
> + if [ ! -d $src ]; then
> + bbfatal "Python source not found at expected location \"$src\". Please check that this task logic and SRC_URI are consistent."
> + fi
> + cd $src
> + ${STAGING_BINDIR_NATIVE}/python3-native/python3 setup.py install \
> + --install-lib=${D}/${PYTHON_SITEPACKAGES_DIR} ${LIBVIRT_INSTALL_ARGS}
> cd -
> fi
> }
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9434): https://lists.yoctoproject.org/g/meta-virtualization/message/9434
> Mute This Topic: https://lists.yoctoproject.org/mt/116155486/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2025-11-19 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:11 [meta-virtualization][PATCH v3] libvirt: Fix missing libvirt-python Tom Hochstein (OSS)
2025-11-19 23:23 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR5RfHEVSHzA0kaX@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=tom.hochstein@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.