From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D029118FDAF; Thu, 20 Nov 2025 00:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763597857; cv=none; b=ENMa+YnakFF9Jo3atcovNhG9bAolqXLNJxUyS9tShTK/PQISeJpEctca5LgWNDpD6HHGBlqp6DIhqrVga6XhjjY/wtnxQ1Bp/fqvwDxgNN34c4DqjhEILaELb+8XTsfUfYwKabtzngNvhRtKP68u+/Mp5PBzB6+4uaCDlxPgHbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763597857; c=relaxed/simple; bh=1cc3DbrfxnW4bVEHX06DIBepzUwipjfMU4MlGRZWJG0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MaWqCa8Z8cZ+TM/T5EpPvumHU/Cy/R2TSht+c8GMaOYifLwFh3bMfLqGfcNqU06xWDBRKZuu9QQEk4mLeY8vCPGizByqLFPHuLCE/XRPHwh6d8Bplmox6ZhyXOKgdR4dKKQW6s5QTcSmpP0qpYqm7CutOQP3tDQTJcm7h8qWQOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=osBQ/xhI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="osBQ/xhI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C04C6C4CEF5; Thu, 20 Nov 2025 00:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763597857; bh=1cc3DbrfxnW4bVEHX06DIBepzUwipjfMU4MlGRZWJG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=osBQ/xhIbE0YvXOjxBfvLIcWf55uqJknH/xyCufQoAD5HqGHsoYR7xTkfpzM3WS93 AnbE4xsplw+aIjfxBnScQIqBoD5tMYR20opCYNNwgDP9arPFLB5ny3OxoinXDGZWtj HrRRpuOliNNGJUrXvqZPyul92tpdl3PW1TjH8QpsuaeMRMNwHHh0SP3cS7jGWwK+Xl rbpXPmpDJzsc7/L+aoVc7dow4FhYhgaGq6z4FWKW5nXvuGSgP1ufjLbSLrI+AhxaLi wVxA6GspZDmXWq2SF+p7zB+DORkv8U8TA2THROjvL3goBeNfP1izbudphVHjek0A86 +OGbWOAJueRHw== Date: Thu, 20 Nov 2025 07:59:47 +0800 From: Jisheng Zhang To: Andy Shevchenko Cc: Hoan Tran , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Michael =?utf-8?B?QsO8c2No?= Subject: Re: [PATCH] gpio: dwapb: Fold dwapb_context into dwapb_gpio_port Message-ID: References: <20251119150049.13537-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Nov 19, 2025 at 07:53:20PM +0200, Andy Shevchenko wrote: > On Wed, Nov 19, 2025 at 11:00:49PM +0800, Jisheng Zhang wrote: > > Fold dwapb_context into struct dwapb_gpio_port to further simplify > > the code. Sure this brings a tiny 36 bytes data overhead for > > !PM_SLEEP. After grepping the arm/arm64/riscv dts dir, the max dwapb > > gpio port number is 6(the berlin2q soc family), so this means we will > > GPIO > > *and I believe this is limitation by Synopsys in HW, but I'm not going to check > the datasheet right now. snps doesn't limit this. The max dwapb gpio controller number is 6 as is grepped the arm/arm64/riscv etc. dts dir. > > > waste 216 bytes memory in total which is trivial compared to the > > system memory. > > > > From another side, as Michael mentioned: > > "The driver currently allocates the struct with kzalloc and stores a > > pointer to it in case of PM=y. > > So this probably has an overhead in the same order of magnitude > > (pointer + malloc overhead/alignment/fragmentation) in case of PM=y > > now." > > > > So let's Fold dwapb_context into struct dwapb_gpio_port. > > > > Signed-off-by: Jisheng Zhang > > > CC: Michael Büsch > > Please, use --cc or move Cc list below... > > > --- > > ...this cutter line. It will have the same effect on the emails, but it will > reduce the noise in the commit message. > > > NOTE: this patch is applied against the following series: > > [PATCH v3 00/15] gpio: Use modern PM macros > > It's better to just put a link to lore.kernel.org or at least message-id. > > ... > > I have a mixed feelings about this, but if maintainers go with it, > let it be then. > > -- > With Best Regards, > Andy Shevchenko > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15E70CF6499 for ; Thu, 20 Nov 2025 00:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C+zuDOQPaCwDQKH6WSNj7i5SDGvuZ2gglyHH7Lvgawg=; b=cng0s/WCW8Rw22 XTQBvrACa1n1eXX9yGSIpEEzd8Kry7+VOMA1gflI5SWbT5facCRHMzBcN1Wv6ytmzJnMoone2GqQo hsFmod6ztJ07j/M5BRM+9d5vxxYWZ1yAuHGlIeKnyw+Pb+I1jNpFpRwAcqTvhk1Av6qFULzHvSMdz M6UuB8Fe2+DK1ROp7vfng9gcULgQ86gHkh+s941Cjmafe1ClKV+nT+KI3H2CIOd144w314PFeIk3g mIitd/jfRaE8XW4pIUBWEvclJGZjJL2dQdKa6n7qLwT1hanWh6ddiVz88OHYYWXGDrGGyDznSr3lO 49NQdrSa6jk9IIR3AIog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLsMl-00000005sor-2qPf; Thu, 20 Nov 2025 00:17:39 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLsMk-00000005sol-2VIL for linux-riscv@lists.infradead.org; Thu, 20 Nov 2025 00:17:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id EECC760010; Thu, 20 Nov 2025 00:17:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C04C6C4CEF5; Thu, 20 Nov 2025 00:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763597857; bh=1cc3DbrfxnW4bVEHX06DIBepzUwipjfMU4MlGRZWJG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=osBQ/xhIbE0YvXOjxBfvLIcWf55uqJknH/xyCufQoAD5HqGHsoYR7xTkfpzM3WS93 AnbE4xsplw+aIjfxBnScQIqBoD5tMYR20opCYNNwgDP9arPFLB5ny3OxoinXDGZWtj HrRRpuOliNNGJUrXvqZPyul92tpdl3PW1TjH8QpsuaeMRMNwHHh0SP3cS7jGWwK+Xl rbpXPmpDJzsc7/L+aoVc7dow4FhYhgaGq6z4FWKW5nXvuGSgP1ufjLbSLrI+AhxaLi wVxA6GspZDmXWq2SF+p7zB+DORkv8U8TA2THROjvL3goBeNfP1izbudphVHjek0A86 +OGbWOAJueRHw== Date: Thu, 20 Nov 2025 07:59:47 +0800 From: Jisheng Zhang To: Andy Shevchenko Cc: Hoan Tran , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Michael =?utf-8?B?QsO8c2No?= Subject: Re: [PATCH] gpio: dwapb: Fold dwapb_context into dwapb_gpio_port Message-ID: References: <20251119150049.13537-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgMTksIDIwMjUgYXQgMDc6NTM6MjBQTSArMDIwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFdlZCwgTm92IDE5LCAyMDI1IGF0IDExOjAwOjQ5UE0gKzA4MDAsIEppc2hl bmcgWmhhbmcgd3JvdGU6Cj4gPiBGb2xkIGR3YXBiX2NvbnRleHQgaW50byBzdHJ1Y3QgZHdhcGJf Z3Bpb19wb3J0IHRvIGZ1cnRoZXIgc2ltcGxpZnkKPiA+IHRoZSBjb2RlLiBTdXJlIHRoaXMgYnJp bmdzIGEgdGlueSAzNiBieXRlcyBkYXRhIG92ZXJoZWFkIGZvcgo+ID4gIVBNX1NMRUVQLiBBZnRl ciBncmVwcGluZyB0aGUgYXJtL2FybTY0L3Jpc2N2IGR0cyBkaXIsIHRoZSBtYXggZHdhcGIKPiA+ IGdwaW8gcG9ydCBudW1iZXIgaXMgNih0aGUgYmVybGluMnEgc29jIGZhbWlseSksIHNvIHRoaXMg bWVhbnMgd2Ugd2lsbAo+IAo+IEdQSU8KPiAKPiAqYW5kIEkgYmVsaWV2ZSB0aGlzIGlzIGxpbWl0 YXRpb24gYnkgU3lub3BzeXMgaW4gSFcsIGJ1dCBJJ20gbm90IGdvaW5nIHRvIGNoZWNrCj4gdGhl IGRhdGFzaGVldCByaWdodCBub3cuCgpzbnBzIGRvZXNuJ3QgbGltaXQgdGhpcy4gVGhlIG1heCBk d2FwYiBncGlvIGNvbnRyb2xsZXIgbnVtYmVyIGlzIDYgYXMKaXMgZ3JlcHBlZCB0aGUgYXJtL2Fy bTY0L3Jpc2N2IGV0Yy4gZHRzIGRpci4KPiAKPiA+IHdhc3RlIDIxNiBieXRlcyBtZW1vcnkgaW4g dG90YWwgd2hpY2ggaXMgdHJpdmlhbCBjb21wYXJlZCB0byB0aGUKPiA+IHN5c3RlbSBtZW1vcnku Cj4gPiAKPiA+IEZyb20gYW5vdGhlciBzaWRlLCBhcyBNaWNoYWVsIG1lbnRpb25lZDoKPiA+ICJU aGUgZHJpdmVyIGN1cnJlbnRseSBhbGxvY2F0ZXMgdGhlIHN0cnVjdCB3aXRoIGt6YWxsb2MgYW5k IHN0b3JlcyBhCj4gPiBwb2ludGVyIHRvIGl0IGluIGNhc2Ugb2YgUE09eS4KPiA+IFNvIHRoaXMg cHJvYmFibHkgaGFzIGFuIG92ZXJoZWFkIGluIHRoZSBzYW1lIG9yZGVyIG9mIG1hZ25pdHVkZQo+ ID4gKHBvaW50ZXIgKyBtYWxsb2Mgb3ZlcmhlYWQvYWxpZ25tZW50L2ZyYWdtZW50YXRpb24pIGlu IGNhc2Ugb2YgUE09eQo+ID4gbm93LiIKPiA+IAo+ID4gU28gbGV0J3MgRm9sZCBkd2FwYl9jb250 ZXh0IGludG8gc3RydWN0IGR3YXBiX2dwaW9fcG9ydC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog SmlzaGVuZyBaaGFuZyA8anN6aGFuZ0BrZXJuZWwub3JnPgo+IAo+ID4gQ0M6IE1pY2hhZWwgQsO8 c2NoIDxtYkBidWVzLmNoPgo+IAo+IFBsZWFzZSwgdXNlIC0tY2Mgb3IgbW92ZSBDYyBsaXN0IGJl bG93Li4uCj4gCj4gPiAtLS0KPiAKPiAuLi50aGlzIGN1dHRlciBsaW5lLiBJdCB3aWxsIGhhdmUg dGhlIHNhbWUgZWZmZWN0IG9uIHRoZSBlbWFpbHMsIGJ1dCBpdCB3aWxsCj4gcmVkdWNlIHRoZSBu b2lzZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCj4gCj4gPiBOT1RFOiB0aGlzIHBhdGNoIGlzIGFw cGxpZWQgYWdhaW5zdCB0aGUgZm9sbG93aW5nIHNlcmllczoKPiA+IFtQQVRDSCB2MyAwMC8xNV0g Z3BpbzogVXNlIG1vZGVybiBQTSBtYWNyb3MKPiAKPiBJdCdzIGJldHRlciB0byBqdXN0IHB1dCBh IGxpbmsgdG8gbG9yZS5rZXJuZWwub3JnIG9yIGF0IGxlYXN0IG1lc3NhZ2UtaWQuCj4gCj4gLi4u Cj4gCj4gSSBoYXZlIGEgbWl4ZWQgZmVlbGluZ3MgYWJvdXQgdGhpcywgYnV0IGlmIG1haW50YWlu ZXJzIGdvIHdpdGggaXQsCj4gbGV0IGl0IGJlIHRoZW4uCj4gCj4gLS0gCj4gV2l0aCBCZXN0IFJl Z2FyZHMsCj4gQW5keSBTaGV2Y2hlbmtvCj4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlz Y3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==