All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
	biju.das.jz@bp.renesas.com,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Add overlay for P3T1085UK-ARD
Date: Thu, 20 Nov 2025 12:07:23 +0100	[thread overview]
Message-ID: <aR72ZPGIJD9JWOCr@tom-desktop> (raw)
In-Reply-To: <aR1f6PMbG0N_9oAo@shikoro>

Hi Wolfram,
Thanks for your review!

On Wed, Nov 19, 2025 at 07:12:56AM +0100, Wolfram Sang wrote:
> 
> > Your suggestion is to keep only Patch 1/2 dropping alias line right?
> 
> Yes.
> 
> We could think about enabling I3C unconditionally by adding this to
> rzg3e-smarc-som.dtsi:

Fine to me. Thank you.

> 
> +       i2c-scl-hz = <400000>;
> +       i3c-scl-hz = <12500000>;
> +       status = "okay";
> 
> So, I3C will just work when you connect devices to it. The I3C frequency
> might be depending a bit on the I3C target board and how it is wired.
> Maybe use 10Mhz as a safe value and add a comment?
> 

Since our current testing setup works fine with 12.5 MHz, I would go with that.
If another target board is used, it can override this value in its board overlay.

I will send v2 addressing your comments.

Kind Regards,
Tommaso


      parent reply	other threads:[~2025-11-20 11:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 14:26 [PATCH 0/2] arm64: dts: renesas: r9a09g047e57-smarc: Enable I3C Tommaso Merciai
2025-11-18 14:26 ` [PATCH 1/2] arm64: dts: renesas: rzg3e-smarc-som: Add I3C support Tommaso Merciai
2025-11-18 16:34   ` Wolfram Sang
2025-11-18 22:19     ` Tommaso Merciai
2025-11-18 14:26 ` [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Add overlay for P3T1085UK-ARD Tommaso Merciai
2025-11-18 16:43   ` Wolfram Sang
2025-11-18 22:28     ` Tommaso Merciai
2025-11-19  6:12       ` Wolfram Sang
2025-11-19  7:17         ` Biju Das
2025-11-19 19:43           ` wsa+renesas
2025-11-20 11:07         ` Tommaso Merciai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR72ZPGIJD9JWOCr@tom-desktop \
    --to=tommaso.merciai.xr@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tomm.merciai@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.