From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: broonie@kernel.org, linus.walleij@linaro.org, andy@kernel.org,
p.zabel@pengutronix.de, linux-gpio@vger.kernel.org,
linux-spi@vger.kernel.org, bartosz.golaszewski@linaro.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] spi: cs42l43: Use actual ACPI firmware node for chip selects
Date: Thu, 20 Nov 2025 10:06:42 +0000 [thread overview]
Message-ID: <aR7oMlVpUL9prRLs@opensource.cirrus.com> (raw)
In-Reply-To: <CAMRc=MdcL0f9aE5emAsFLmwZoN5_-qM4JCSzP6D3J8D1PrsaEg@mail.gmail.com>
On Thu, Nov 20, 2025 at 10:29:41AM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 19, 2025 at 5:40 PM Charles Keepax
> <ckeepax@opensource.cirrus.com> wrote:
> > + props = devm_kmemdup(priv->dev, cs42l43_cs_props, sizeof(cs42l43_cs_props),
> > + GFP_KERNEL);
> > + if (!props)
> > + return -ENOMEM;
>
> You don't need to allocate it for more than the duration of this
> function, device_create_managed_software_node() makes a deep copy of
> the properties. They can be on the stack.
Good point, thanks will fixup for v2. Should be able to send that
later today.
> This is looking good, if you post a v2 and it's reviewed, I can resend
> my series with this included and maybe it'll still make v6.19.
Cool yeah I am fine with you pulling this into your series once I
have sent the v2.
Thanks,
Charles
prev parent reply other threads:[~2025-11-20 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 16:40 [PATCH] spi: cs42l43: Use actual ACPI firmware node for chip selects Charles Keepax
2025-11-19 16:45 ` Charles Keepax
2025-11-19 16:51 ` Andy Shevchenko
2025-11-19 16:49 ` Andy Shevchenko
2025-11-19 17:04 ` Charles Keepax
2025-11-20 9:23 ` kernel test robot
2025-11-20 9:29 ` Bartosz Golaszewski
2025-11-20 10:06 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR7oMlVpUL9prRLs@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.