From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>,
Maciej Strozek <mstrozek@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Andy Shevchenko <andy@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-spi@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
stable+noautosel@kernel.org
Subject: Re: [PATCH v7 0/9] reset: rework reset-gpios handling
Date: Thu, 20 Nov 2025 17:06:21 +0200 [thread overview]
Message-ID: <aR8ubexLrTgmxtpv@smile.fi.intel.com> (raw)
In-Reply-To: <20251120-reset-gpios-swnodes-v7-0-a100493a0f4b@linaro.org>
On Thu, Nov 20, 2025 at 02:23:55PM +0100, Bartosz Golaszewski wrote:
> Machine GPIO lookup is a nice, if a bit clunky, mechanism when we have
> absolutely no idea what the GPIO provider is or when it will be created.
> However in the case of reset-gpios, we not only know if the chip is
> there - we also already hold a reference to its firmware node.
>
> In this case using fwnode lookup makes more sense. However, since the
> reset provider is created dynamically, it doesn't have a corresponding
> firmware node (in this case: an OF-node). That leaves us with software
> nodes which currently cannot reference other implementations of the
> fwnode API, only other struct software_node objects. This is a needless
> limitation as it's imaginable that a dynamic auxiliary device (with a
> software node attached) would want to reference a real device with an OF
> node.
>
> This series does three things: extends the software node implementation,
> allowing its properties to reference not only static software nodes but
> also existing firmware nodes, updates the GPIO property interface to use
> the reworked swnode macros and finally makes the reset-gpio code the
> first user by converting the GPIO lookup from machine to swnode.
>
> Another user of the software node changes in the future could become the
> shared GPIO modules that's in the works in parallel[1].
>
> Merging strategy: the series is logically split into four parts: driver
> core, SPI, GPIO and reset respectively. However there are build-time
> dependencies between all three parts so I suggest the reset tree as the
> right one to take it upstream with an immutable branch provided to
> driver core, SPI and GPIO.
Solution seems still OF-centric (some of_* is in reset-gpio are left),
but the series in the right direction, thanks for doing this!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-20 15:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 13:23 [PATCH v7 0/9] reset: rework reset-gpios handling Bartosz Golaszewski
2025-11-20 13:23 ` [PATCH v7 1/9] software node: read the reference args via the fwnode API Bartosz Golaszewski
2025-11-20 13:25 ` Charles Keepax
2025-11-20 13:26 ` Charles Keepax
2025-11-20 14:47 ` Andy Shevchenko
2025-11-20 13:23 ` [PATCH v7 2/9] software node: increase the reference of the swnode by its fwnode Bartosz Golaszewski
2025-11-20 13:26 ` Charles Keepax
2025-11-20 14:48 ` Andy Shevchenko
2025-11-20 13:23 ` [PATCH v7 3/9] software node: allow referencing firmware nodes Bartosz Golaszewski
2025-11-20 13:27 ` Charles Keepax
2025-11-20 13:23 ` [PATCH v7 4/9] spi: cs42l43: Use actual ACPI firmware node for chip selects Bartosz Golaszewski
2025-11-20 14:53 ` Andy Shevchenko
2025-11-20 15:40 ` Mark Brown
2025-11-24 16:58 ` Charles Keepax
2025-11-24 17:48 ` Bartosz Golaszewski
2025-11-20 13:24 ` [PATCH v7 5/9] gpio: swnode: allow referencing GPIO chips by firmware nodes Bartosz Golaszewski
2025-11-20 13:24 ` [PATCH v7 6/9] reset: order includes alphabetically in reset/core.c Bartosz Golaszewski
2025-11-20 13:24 ` [PATCH v7 7/9] reset: make the provider of reset-gpios the parent of the reset device Bartosz Golaszewski
2025-11-20 13:24 ` [PATCH v7 8/9] reset: gpio: convert the driver to using the auxiliary bus Bartosz Golaszewski
2025-11-20 13:24 ` [PATCH v7 9/9] reset: gpio: use software nodes to setup the GPIO lookup Bartosz Golaszewski
2025-11-20 15:06 ` Andy Shevchenko [this message]
2025-11-20 15:29 ` [PATCH v7 0/9] reset: rework reset-gpios handling Bartosz Golaszewski
2025-11-20 16:32 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR8ubexLrTgmxtpv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dakr@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=p.zabel@pengutronix.de \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable+noautosel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.