All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryant Boatright <bryant.boatright@proton.me>
To: Michael Straube <straube.linux@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration
Date: Mon, 10 Nov 2025 17:24:02 +0000	[thread overview]
Message-ID: <aRIfq9sDa2Neok1W@ubuntu-desk> (raw)
In-Reply-To: <f367735d-e480-4eb1-a2a9-c6d311661fdd@gmail.com>

On Sat, Nov 08, 2025 at 06:51:45AM +0100, Michael Straube wrote:
> Hi Bryant,
> 
> Am 08.11.25 um 05:54 schrieb Bryant Boatright:
> > -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> > +enum parse_res { parse_ok = 0, parse_unknown = 1, parse_failed = -1 };
> 
> The constants in enums are usually named all upper case.
> PARSE_OK, PARSE_UNKNOWN, PARSE_FAILED
> 
> Best regards,
> Michael

Michael,

Thanks for the feedback, I'll correct that and resubmit in a
V2 patchset.

Best,
Bryant


  reply	other threads:[~2025-11-10 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-08  4:54 [PATCH 0/3] Checkpatch cleanup patches Bryant Boatright
2025-11-08  4:54 ` [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration Bryant Boatright
2025-11-08  5:51   ` Michael Straube
2025-11-10 17:24     ` Bryant Boatright [this message]
2025-11-08  4:55 ` [PATCH 2/3] staging: rtl8723bs: Rename camel case argument Bryant Boatright
2025-11-08  4:55 ` [PATCH 3/3] staging: rtl8723bs: Rename camel case variable Bryant Boatright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRIfq9sDa2Neok1W@ubuntu-desk \
    --to=bryant.boatright@proton.me \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.