From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: Tanmay Shah <tanmay.shah@amd.com>,
andersson@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] remoteproc: xlnx: remote crash recovery
Date: Mon, 10 Nov 2025 11:03:04 -0700 [thread overview]
Message-ID: <aRIo2MUol09Onu9B@p14s> (raw)
In-Reply-To: <20251030042124.GA18595@nxa18884-linux.ap.freescale.net>
On Thu, Oct 30, 2025 at 12:21:24PM +0800, Peng Fan wrote:
> Hi Tanmay,
>
> On Wed, Oct 29, 2025 at 06:51:51PM -0500, Tanmay Shah wrote:
> ...
> >> >
> >>
> >> Hi Peng,
> >>
> >> I don't understand why it should fail. The patch simply implements
> >> rproc_detach() -> rproc_attach() sequence.
> >>
> >
> >Hi Peng,
> >
> >Thanks for testing the patch. I appreciate your quick response. I think
> >rproc_boot() should be used instead of rproc_attach(). That should probably
> >solve the issue you are facing. I will send v2 with this change for you to
> >try.
> >
> >Thanks,
> >Tanmay
> >
> >> In your case, when you do detach -> attach via sysfs that sequence works?
> >> If that works, then crash recovery should work as well.
>
> sysfs does not have attach option, only start/stop/detach are there.
>
> >>
> >> Could you give steps how do you generate the crash?
>
> I have not look into the details on why it fails at my side for the 2nd time.
>
> On my board, the M4 core use watchdog to reset itself and notify Linux, then
> linux side imx_rproc driver will do
> "rproc_report_crash(priv->rproc, RPROC_WATCHDOG);"
>
> I will give a debug on the failures in a few days.
>
So what is happening here - Peng, do you plan on providing more debugging
information? Tanmay - are you planning on sending a second revision?
> Thanks,
> Peng
>
> >>
> >> Thanks,
> >> Tanmay
> >>
> >> > Thanks,
> >> > Peng
> >>
> >
next prev parent reply other threads:[~2025-11-10 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 4:57 [PATCH 0/3] remoteproc: xlnx: remote crash recovery Tanmay Shah
2025-10-28 4:57 ` [PATCH 1/3] remoteproc: xlnx: enable boot recovery Tanmay Shah
2025-10-28 4:57 ` [PATCH 2/3] remoteproc: core: full attach detach during recovery Tanmay Shah
2025-10-29 22:49 ` Iuliana Prodan
2025-10-29 23:41 ` Tanmay Shah
2025-11-02 8:54 ` Zhongqiu Han
2025-11-03 17:22 ` Tanmay Shah
2025-10-28 4:57 ` [PATCH 3/3] remoteproc: xlnx: add crash detection mechanism Tanmay Shah
2025-10-29 3:24 ` [PATCH 0/3] remoteproc: xlnx: remote crash recovery Peng Fan
2025-10-29 4:15 ` Tanmay Shah
2025-10-29 23:51 ` Tanmay Shah
2025-10-30 4:21 ` Peng Fan
2025-11-10 18:03 ` Mathieu Poirier [this message]
2025-11-10 18:39 ` Tanmay Shah
2025-11-11 7:12 ` Peng Fan
2025-11-11 16:47 ` Tanmay Shah
-- strict thread matches above, loose matches on Subject: below --
2025-11-13 15:44 Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRIo2MUol09Onu9B@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=peng.fan@oss.nxp.com \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.