From: Simon Horman <horms@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
mbloch@nvidia.com, Adithya Jayachandran <ajayachandra@nvidia.com>
Subject: Re: [PATCH net-next V2 2/3] net/mlx5: MPFS, add support for dynamic enable/disable
Date: Tue, 11 Nov 2025 14:27:45 +0000 [thread overview]
Message-ID: <aRNH4aEOOTISkIj4@horms.kernel.org> (raw)
In-Reply-To: <aQ-cWqrZr_1qkgCm@x130>
On Sat, Nov 08, 2025 at 11:39:06AM -0800, Saeed Mahameed wrote:
> On 08 Nov 15:21, Simon Horman wrote:
> > On Thu, Nov 06, 2025 at 04:08:30PM -0800, Saeed Mahameed wrote:
...
> > I realise that error handling can be complex at best, and particularly
> > so when configuration ends up being partially applied. But I am wondering
> > if the cleanup here is sufficient.
> >
>
> Cleanup is sufficient, the use of index -1 is an indication of the entry was
> not successfully written to HW, so only if index is positive we will delete
> it from hw on cleanup.
>
> > In a similar vein, I also note that although this function returns an
> > error, it is ignored by callers which are added by the following patch.
> > Likewise for mlx5_esw_fdb_drop_create() which is also added by the
> > following patch.
> >
>
> This is best effort as there could be a lot of l2 entries and we might run
> out of space, we don't want to cripple the whole system just because one VF
> mac didn't make it to the mpfs table, the approach here is similar to
> set_rx_mode ndo expectation, which this function also serves.
>
Thanks for the clarification, I agree this is a reasonable approach.
next prev parent reply other threads:[~2025-11-11 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 0:08 [PATCH net-next V2 0/3] devlink eswitch inactive mode Saeed Mahameed
2025-11-07 0:08 ` [PATCH net-next V2 1/3] devlink: Introduce switchdev_inactive eswitch mode Saeed Mahameed
2025-11-07 0:08 ` [PATCH net-next V2 2/3] net/mlx5: MPFS, add support for dynamic enable/disable Saeed Mahameed
2025-11-08 15:21 ` Simon Horman
2025-11-08 19:39 ` Saeed Mahameed
2025-11-11 14:27 ` Simon Horman [this message]
2025-11-07 0:08 ` [PATCH net-next V2 3/3] net/mlx5: E-Switch, support eswitch inactive mode Saeed Mahameed
2025-11-08 2:28 ` Jakub Kicinski
2025-11-08 4:53 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRNH4aEOOTISkIj4@horms.kernel.org \
--to=horms@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.