Re: [PATCH] iomap: replace folio_batch allocation with stack allocation

[Christoph Hellwig <hch@infradead.org>]

On Tue, Nov 11, 2025 at 12:50:47PM -0500, Brian Foster wrote:
>  		if (imap.br_state == XFS_EXT_UNWRITTEN &&
>  		    offset_fsb < eof_fsb) {
> -			loff_t len = min(count,
> -					 XFS_FSB_TO_B(mp, imap.br_blockcount));
> +			loff_t foffset = offset, fend;
>  
> -			end = iomap_fill_dirty_folios(iter, offset, len);
> +			fend = offset +
> +			       min(count, XFS_FSB_TO_B(mp, imap.br_blockcount));
> +			iomap_flags |= iomap_fill_dirty_folios(iter, &foffset,
> +							       fend);
>  			end_fsb = min_t(xfs_fileoff_t, end_fsb,
> -					XFS_B_TO_FSB(mp, end));
> +					XFS_B_TO_FSB(mp, foffset));

Maybe it's just me, but I found the old calling convention a lot more
logic.  Why not keep it and extend it for passing the flags as an
in/out argument?  That would also keep the churn down a bit.

Otherwise the change looks good.