From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, Miaoqian Lin <linmq006@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves
Date: Wed, 12 Nov 2025 17:07:08 +0530 [thread overview]
Message-ID: <aRRxZCWCWMFD23b4@vaman> (raw)
In-Reply-To: <7eed86f6-97a9-487a-8161-3617597f7391@oss.qualcomm.com>
On 12-11-25, 10:09, Srinivas Kandagatla wrote:
>
>
> On 11/12/25 5:13 AM, Vinod Koul wrote:
> >
> > On Mon, 27 Oct 2025 14:06:01 +0800, Miaoqian Lin wrote:
> >> The function qcom_slim_ngd_notify_slaves() calls of_slim_get_device() which
> >> internally uses device_find_child() to obtain a device reference.
> >> According to the device_find_child() documentation,
> >> the caller must drop the reference with put_device() after use.
> >>
> >> Found via static analysis and this is similar to commit 4e65bda8273c
> >> ("ASoC: wcd934x: fix error handling in wcd934x_codec_parse_data()")
> >>
> >> [...]
> >
> > Applied, thanks!
>
> These are slimbus patches? any reason why they are going via soundwire tree?
My mistake, sorry :-( dropped now
--
~Vinod
prev parent reply other threads:[~2025-11-12 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 6:06 [PATCH] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves Miaoqian Lin
2025-10-27 14:39 ` Dmitry Baryshkov
2025-11-10 7:25 ` Srinivas Kandagatla
2025-11-12 5:13 ` Vinod Koul
2025-11-12 10:09 ` Srinivas Kandagatla
2025-11-12 11:37 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRxZCWCWMFD23b4@vaman \
--to=vkoul@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linmq006@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.