From: Marek Marczykowski <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Daniel Smith" <dpsmith@apertussolutions.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 2/3] x86/EFI: replace ebmalloc()
Date: Thu, 13 Nov 2025 13:59:26 +0100 [thread overview]
Message-ID: <aRXWLrEGbSRdqDA7@mail-itl> (raw)
In-Reply-To: <4391d560-870e-4010-b3bb-dee2935f9732@suse.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Nov 13, 2025 at 01:46:20PM +0100, Jan Beulich wrote:
> On 13.11.2025 13:40, Marek Marczykowski wrote:
> > On Thu, Nov 13, 2025 at 12:09:37PM +0100, Jan Beulich wrote:
> >> --- a/xen/arch/x86/include/asm/brk.h
> >> +++ b/xen/arch/x86/include/asm/brk.h
> >> @@ -2,6 +2,10 @@
> >>
> >> #include <xen/types.h>
> >>
> >> +#define DEFINE_BRK(var, size) \
> >> + static char __section(".bss..brk.page_aligned") __aligned(PAGE_SIZE) \
> >> + __used var ## _brk_[size]
> >
> > This chunk belongs to the previous patch I think.
>
> It could, but it's not used there yet (i.e. would count as dead code).
But in the current shape the linker script change in the first patch is
unused. IOW, I think adding .bss..brk.page_aligned to the linker script
should go together with DEFINE_BRK.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-11-13 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:06 [PATCH 0/3] x86: "brk" allocator Jan Beulich
2025-11-13 11:08 ` [PATCH 1/3] x86: introduce " Jan Beulich
2025-11-13 17:41 ` Marek Marczykowski-Górecki
2025-11-14 7:56 ` Jan Beulich
2025-11-13 11:09 ` [PATCH 2/3] x86/EFI: replace ebmalloc() Jan Beulich
2025-11-13 12:40 ` Marek Marczykowski
2025-11-13 12:46 ` Jan Beulich
2025-11-13 12:59 ` Marek Marczykowski [this message]
2025-11-13 13:24 ` Jan Beulich
2025-11-13 17:30 ` Marek Marczykowski
2025-11-13 12:53 ` Jan Beulich
2025-11-13 13:01 ` Marek Marczykowski
2025-11-13 11:10 ` [PATCH 3/3] xhci-dbc: use brk_alloc() Jan Beulich
2025-11-13 12:39 ` Marek Marczykowski
2025-11-13 12:50 ` Jan Beulich
2025-11-13 13:01 ` Marek Marczykowski
2025-11-13 15:29 ` [PATCH 0/3] x86: "brk" allocator Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRXWLrEGbSRdqDA7@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dpsmith@apertussolutions.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.