All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Clément Léger" <clement.leger@bootlin.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: pcs: renesas,rzn1-miic: Add renesas,miic-phylink-active-low property
Date: Thu, 13 Nov 2025 15:58:05 +0000	[thread overview]
Message-ID: <aRYADfD8QkIw9Fnd@shell.armlinux.org.uk> (raw)
In-Reply-To: <CA+V-a8s5fg02ZQT4tubJ46iBFtNXJRvTPp2DLJgeFnb3eMQPfg@mail.gmail.com>

On Thu, Nov 13, 2025 at 02:45:18PM +0000, Lad, Prabhakar wrote:
> Hi Wolfram,
> 
> On Wed, Nov 12, 2025 at 8:40 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> >
> > Hi Prabhakar,
> >
> > > Add the boolean DT property `renesas,miic-phylink-active-low` to the RZN1
> >
> > Hmm, we already have "renesas,ether-link-active-low" in
> > renesas,ether.yaml and renesas,etheravb.yaml. Can't we reuse that?
> >
> On the RZ/N1x we have the below architecture
> 
>                                                       +----> Ethernet Switch
>                                                       |           |
>                                                       |           v
>     MII Converter ----------------------+      GMAC (Synopsys IP)
>                                                       |
>                                                       +----> EtherCAT
> Slave Controller
>                                                       |
>                                                       +----> SERCOS
> Controller

I'm not sure that diagram has come out correctly. If you're going to
draw diagrams, make sure you do it using a fixed-width font. To me,
it looks like the MII Converter is bolted to GMAC and only has one
connection, and the GMAC has what seems to be maybe five connections.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-11-13 15:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 20:19 [PATCH net-next 0/2] Add support for PHY link active-level configuration in RZN1 MIIC driver Prabhakar
2025-11-12 20:19 ` [PATCH net-next 1/2] dt-bindings: net: pcs: renesas,rzn1-miic: Add renesas,miic-phylink-active-low property Prabhakar
2025-11-12 20:40   ` Wolfram Sang
2025-11-13 14:45     ` Lad, Prabhakar
2025-11-13 15:58       ` Russell King (Oracle) [this message]
2025-11-13 19:05         ` Lad, Prabhakar
2025-11-13 19:10           ` Lad, Prabhakar
2025-11-12 20:57   ` Andrew Lunn
2025-11-13 18:53     ` Lad, Prabhakar
2025-11-13 21:58       ` Andrew Lunn
2025-11-26 20:55         ` Lad, Prabhakar
2025-11-26 21:28           ` Andrew Lunn
2026-01-09  9:18             ` Lad, Prabhakar
2025-11-12 20:19 ` [PATCH net-next 2/2] net: pcs: rzn1-miic: Add support for PHY link active-level configuration Prabhakar
2025-11-12 21:00   ` Andrew Lunn
2025-11-12 22:11   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRYADfD8QkIw9Fnd@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew+netdev@lunn.ch \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=clement.leger@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.