From: Ido Schimmel <idosch@nvidia.com>
To: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Cc: Petr Machata <petrm@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH net] net: mlxsw: linecards: fix missing error check in mlxsw_linecard_devlink_info_get()
Date: Thu, 13 Nov 2025 21:15:14 +0200 [thread overview]
Message-ID: <aRYuQpOqe6FOM7CI@shredder> (raw)
In-Reply-To: <20251113161922.813828-1-Pavel.Zhigulin@kaspersky.com>
On Thu, Nov 13, 2025 at 07:19:21PM +0300, Pavel Zhigulin wrote:
> The call to devlink_info_version_fixed_put() in
> mlxsw_linecard_devlink_info_get() did not check for errors,
> although it is checked everywhere in the code.
>
> Add missed 'err' check to the mlxsw_linecard_devlink_info_get()
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 3fc0c51905fb ("mlxsw: core_linecards: Expose device PSID over device info")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-11-13 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 16:19 [PATCH net] net: mlxsw: linecards: fix missing error check in mlxsw_linecard_devlink_info_get() Pavel Zhigulin
2025-11-13 19:15 ` Ido Schimmel [this message]
2025-11-15 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRYuQpOqe6FOM7CI@shredder \
--to=idosch@nvidia.com \
--cc=Pavel.Zhigulin@kaspersky.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.