Re: [PATCH v8 3/4] drm/xe/pm: Assert on runtime suspend if VFs are enabled

[Raag Jadav <raag.jadav@intel.com>]

On Tue, Nov 04, 2025 at 12:15:41PM +0100, Raag Jadav wrote:
> On Fri, Oct 31, 2025 at 04:04:30PM +0100, Raag Jadav wrote:
> > On Thu, Oct 30, 2025 at 11:33:38AM -0700, Daniele Ceraolo Spurio wrote:
> > > On 10/30/2025 5:23 AM, Raag Jadav wrote:
> > > > We hold an additional reference to the runtime PM to keep PF in D0
> > > > during VFs lifetime, as our VFs do not implement the PM capability.
> > > > This means we should never be runtime suspending as long as VFs are
> > > > enabled.
> > > > 
> > > > v8: Add !IS_SRIOV_VF() assert (Matthew Brost)
> > > > 
> > > > Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > 
> > > Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > 
> > Thank you.
> > 
> > So I'm guessing this series is good to go?
> 
> Or perhaps anything else I can do here?

Is this still on the cards by any chance?

Raag

> > > > ---
> > > >   drivers/gpu/drm/xe/xe_pci.c | 9 +++++++++
> > > >   1 file changed, 9 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> > > > index 6e59642e7820..1c37f4d91047 100644
> > > > --- a/drivers/gpu/drm/xe/xe_pci.c
> > > > +++ b/drivers/gpu/drm/xe/xe_pci.c
> > > > @@ -1152,6 +1152,15 @@ static int xe_pci_runtime_suspend(struct device *dev)
> > > >   	struct xe_device *xe = pdev_to_xe_device(pdev);
> > > >   	int err;
> > > > +	/*
> > > > +	 * We hold an additional reference to the runtime PM to keep PF in D0
> > > > +	 * during VFs lifetime, as our VFs do not implement the PM capability.
> > > > +	 * This means we should never be runtime suspending as long as VFs are
> > > > +	 * enabled.
> > > > +	 */
> > > > +	xe_assert(xe, !IS_SRIOV_VF(xe));
> > > > +	xe_assert(xe, !pci_num_vf(pdev));
> > > > +
> > > >   	err = xe_pm_runtime_suspend(xe);
> > > >   	if (err)
> > > >   		return err;
> > >