From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E60C2331218 for ; Fri, 14 Nov 2025 15:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134606; cv=none; b=pLBTVQsJ1ETzCSqBYhWLq0UW4PFROs1wnddIcQlntbPG2uAa1SEVkgHKBR0TSjh4WcZTEs9VqCC/D/4onDj/1zjq8GJuSVJ8dudFUk8Dhu6lsw45yxg4rU5dZUlOv7kwaVPNdVQRiAUSJYhxlAJAS90L41klPtr0couauAiyZw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134606; c=relaxed/simple; bh=15XVlWmeXbX277AlFhQaOJoMEiXsy5IPAjqS8/jXYq8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D3N8vQtsYTRJCYqG0/Ic7UqD7aOFjv2NmoTAICSMhknoxmTN080tIa4xMv0r2e7udOD8DYPoY0b32Dtozbv/mq0K1MUtFH67JO6TQ9dLB/VCgK4TdzNl/bTbhDtkEiQlM2VhmD0rz4a+4JzRpaY1q8QtKaijr9WFB3yni4R6lPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bG/iKGjn; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bG/iKGjn" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-641977dc00fso3129846a12.1 for ; Fri, 14 Nov 2025 07:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763134602; x=1763739402; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5uK/EkPpYUws7gS2lTTvKkj1O4DYP4QzLzVPXUFYxv4=; b=bG/iKGjnm5FJhZZisXhZ0357++gohK39V7uJCu0f2BRK7/KPcYVKgr2epE0WDSkI12 imMkJPkG6gANy5/wL48OZJXS/mVkbe3N2r8k6zrzW9LP9q3+Cna8wKp7U/pJAUpPxEZa IvJkm2Iu7lFZ+JdbcsvqQ6qEOZ2brhw8Pd9BfOP+zAKKlsKRFDxDKiPzkYP4QiyHNy1e 7NdF79R9lUs7e++Op/X5nEaNzKhytsAQV/e5o7k9U39wRMHrNiVUupK4d+2ud4Jbyf8k oBO83a7QMuOr926R+NScUaMR5wGLGNOThcRQ9I4U3Z4OmhrCaTiXcQ8dW7Rx+QDx+Yyu 9qZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763134602; x=1763739402; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5uK/EkPpYUws7gS2lTTvKkj1O4DYP4QzLzVPXUFYxv4=; b=jV8deYtsVUAdD7ov7Kyr4C9nRLKOes7TNDQ8yePzLfry1hCNner62gn7hhwpkZolBx gWo5SS9jBTlsYqqy/hMiuH+5VhbXPLs1kg+VsKJb0+vnFJEWm28u/bZvUHNkpt0p0oG3 bOyPgq6ne7ngHJk5h3OSiw6aUvmdLGd1S2pFaa5cIXRQxbdzG3nfdnh2gHhvNHjdtpq9 e9ckKClKfYI/f73a33UAQ7fJeLRroF12Lvgt1uOQNCNsvd9zPGxA2IulkcgvTAJ03dMq ee4HsWsp5sRb8LSklTU0Yif9Dt5ytWp98jb8cExE7/4B4XEOdRdFvkUnxIecTNqJdaRk uMDg== X-Forwarded-Encrypted: i=1; AJvYcCUX1rhr+r1pBnKSb6WrTnAqpdCZZbgQ2oSL/7ZaatU4YBAMBtoWY9cv16wQblJG5UAVVveDw3YK+eZawWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy6DTYwMbsssxzaWlaKY0WIctnPd8oP8ao760ceBA5QWfjjH4q 2omwnbbdXg1gKWNN4P3jwqoe7oLmdNpEKBMj6MxduSFG+SfY5AerF5Dk4jkH156DTr8= X-Gm-Gg: ASbGnct+DRdVQ5NPJriClB2wCa5kiJzd5rTBUTCUlQa+ez8R4JhHfLFiUhXmObepHHp HKoIOqMyoz2hjqnFUF4+jqx6DNOpY7tNdbvNXuJGRsm8HyXriu2Dm64B2xRyaevhgjwkyAe2fvT X5Pxeu03F8NC2XZ3aT5X9OUE+GB8l6nBZ5vzGtOQfCahkT7BFma1mgqbpdYsVDurFazzLniRam3 4cEUBBi2PME6sDkIVSIJi8egwFJf1AIRWmsYA+jlO5i0AUTnLktGGklkJ2zIPenCNwcJvZCe4Fy AMrYubOtHO2wV+F+8gvL8Pv+vP5vHBa/i2xCHXfLexRUEIfCQvccupdLCruiQ4YUMPblqACMNPk 9CHSzmVfP99EevNeiS5Gf3xtXUkeMEmhCD1z+oUEh5GgWOD39ePiIm0fSHV3zfBsUL3JnnedzR8 yhanQ= X-Google-Smtp-Source: AGHT+IEjrf3pe6Wh6Ehi37ZfGQV0y1rWJOPkMVKbwBe3q/IV7R1fqkoJs16n7NqPEL5Uju0kzbevOA== X-Received: by 2002:a05:6402:90e:b0:640:bbd1:7d99 with SMTP id 4fb4d7f45d1cf-64350e204f7mr3008116a12.16.1763134602201; Fri, 14 Nov 2025 07:36:42 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a498102sm3953604a12.24.2025.11.14.07.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 07:36:41 -0800 (PST) Date: Fri, 14 Nov 2025 16:36:39 +0100 From: Petr Mladek To: Feng Tang Cc: Andrew Morton , Lance Yang , Jonathan Corbet , paulmck@kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] hung_task: Add hung_task_sys_info sysctl to dump sys info on task-hung Message-ID: References: <20251113111039.22701-1-feng.tang@linux.alibaba.com> <20251113111039.22701-3-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113111039.22701-3-feng.tang@linux.alibaba.com> On Thu 2025-11-13 19:10:37, Feng Tang wrote: > When task-hung happens, developers may need different kinds of system > information (call-stacks, memory info, locks, etc.) to help debugging. > > Add 'hung_task_sys_info' sysctl knob to take human readable string like > "tasks,mem,timers,locks,ftrace,...", and when task-hung happens, all > requested information will be dumped. (refer kernel/sys_info.c for more > details). > > Meanwhile, the newly introduced sys_info() call is used to unify some > existing info-dumping knobs. > > Suggested-by: Petr Mladek > Signed-off-by: Feng Tang It would have been better to split the refactoring (moving some logic from check_hung_task()) into a separate patch. But the result looks good. Feel free to use: Reviewed-by: Petr Mladek Best Regards, Petr