From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D67178F51 for ; Fri, 14 Nov 2025 15:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763135073; cv=none; b=ikVH6MLUDXVAbSM74gdrtrU6NKQ4+tzqfkW/3fuhQe1sDKZmcwmjKoicY6bQ7Wu0IJp92VyJlxD/pnr/vXqdhN/V40EmQ/Jx6VpiXRlUQ+flYEmysM5Edi3d20/UcPKsHP+COa4nPYycG+LVHpffiVoPY3ZVI5SsVpN45wmyj5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763135073; c=relaxed/simple; bh=DIgteVunBYU8Tld1Qi/KcQofIGVirEK/6BOM1yABrCM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BFNWc7unhxdKUVJNWG14dWItlvl2B4D/wT32XE6YDRKMB3cnBIREOP25Bv3wVAQP1N4Tobi/WyP9Q5lsF/GQSCCBdnN7roSJ920XkliBk2yQLz/QI9NicZU1JT1vJct+SV+9RWpeTw9UAMSC98Qsry92X+WMYk6395mwCB1h+6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=MLo7bSRm; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="MLo7bSRm" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-641677916b5so3899541a12.0 for ; Fri, 14 Nov 2025 07:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763135069; x=1763739869; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qQXIX71OwpAiaeFKlGr9jClioij60ZWKpMOmGIMI3xY=; b=MLo7bSRmPLQvVLsvj2qzWnThPz0vfthBHyrCSreanM4gZFmYCBiUFUQnYMDl9mIhzP ye0J1poa8iM8tfY0BbyASIy1dhMVglSK84eVw3EB+oIsENfhYApdKAO0nWqTC53MXOpC ROBAiNat8ciSAd9wrcYQqBiiXWGohIAzTZ392oKSK1/6qIDODOhqp/ZH6qibTYh830BU tB56typB7+zVWETLabfy9iBMk2u/N7KY6l+AEF72EzZdDIQp460wDEKEL+oSDG/mhbMh i1lA5rhHe//8C8gHaWJX9JOkQ2fMimZpDrX461B4DwKzc0HKsA/bfmqHXnfAbaS9j9Jx 7JgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763135069; x=1763739869; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qQXIX71OwpAiaeFKlGr9jClioij60ZWKpMOmGIMI3xY=; b=PxFhNXEmy49HRwLxZ3jM4/yf3Yirau/d5bvtMlraj7RHqbQcauDpurDtS+8YCRS2UT +gZMgJ9nPkE4nTq+gtQQv/+jWKTT1eRT7ef/eaq0P3Kf49bKS3gSmw7W/Q8c6+5BR/3i BahHrPcKlVPK3jqzrMZBn3rnB62DC0Rhmmol53bXPAktRCm7DkY3nZyJU7t5zqbngS90 16kuJeeLPvBkSrwtX9Vm5i3vy5KhY1T4WpFHVPakqjwO15FCf11rAnQqW+SaoRt8GYhP YTMZMY7tMFL4D154/fNzoWSXympCKmmwynaelWMdopRIea9Pbx5lJFVt7Ghnpl+i+jFn ExMw== X-Forwarded-Encrypted: i=1; AJvYcCVfZtBknVjxGMJJ+n5bn3PdbtqHeUPmgCzVg8KL03045AsCNtva4cARyDunX1+SraLyttj3hF0KOUK0kkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2cZJoupTnRZ3zfzJzLfNdw/RfJqMEFQyel55teeRUIhTBqw9F nILthf7k6Qh9YdYE+mNrTB3VPvGYentRBonLs9RtF/upiroSDdG8dsu9aUXaYl2vRYQ= X-Gm-Gg: ASbGnctd/ki3f9sloe6syMRWl3ovyJYEAZs8ZuDVSc/KqXcQGXCWhxuJP3Bof1NtgOS j8DoH5AIM+a+jqhuprJF3aLzV0SU/RJh+aOWjT9cA/4/cRsxaZge9F9Sb78+jGc/qMkGV9snwAE t9IobRpZPQ3pIQEgR8R2+5vJciSKPzzw8l5GlNoVHfWNzTVTVuQ//r/vdmuA6ZDArJxKf8uZvXZ a9XyLzc0g6Y8UGLHp+TDqKj8BwBZzAQRNcv1zehLkjVHRcuaoMSj0/gKIboDhBLlpu7bXM7DZSj wFWPvVocof0vzcJgnqCARTv/a3opTHrriprJuh/aV/U6FAwJKgGPSEwTv1tGCh5kVBUQ83jKAs4 UjIMGuQcjT3ImZxuGZlj2fjqNh51VVOYRGoSl8xRZEIcHwE4VgH97qyWz/1ppcwphOtBmlu6MTk IRw/c= X-Google-Smtp-Source: AGHT+IEoti2L5osnxMvbGoPwKOrsXUuEkjWDzXaAG3OF2Bi8UE2gieqWjkOTO2OpohedQ7RgqPWyow== X-Received: by 2002:a05:6402:3546:b0:640:825e:ae82 with SMTP id 4fb4d7f45d1cf-64350e9bb8bmr2801190a12.29.1763135068908; Fri, 14 Nov 2025 07:44:28 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a4b2615sm3891320a12.32.2025.11.14.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 07:44:28 -0800 (PST) Date: Fri, 14 Nov 2025 16:44:26 +0100 From: Petr Mladek To: Feng Tang Cc: Andrew Morton , Lance Yang , Jonathan Corbet , paulmck@kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] watchdog: add sys_info sysctls to dump sys info on system lockup Message-ID: References: <20251113111039.22701-1-feng.tang@linux.alibaba.com> <20251113111039.22701-4-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113111039.22701-4-feng.tang@linux.alibaba.com> On Thu 2025-11-13 19:10:38, Feng Tang wrote: > When soft/hard lockup happens, developers may need different kinds of > system information (call-stacks, memory info, locks, etc.) to help > debugging. > > Add 'softlockup_sys_info' and 'hardlockup_sys_info' sysctl knobs to > take human readable string like "tasks,mem,timers,locks,ftrace,...", > and when system lockup happens, all requested information will be > printed out. (refer kernel/sys_info.c for more details). > > Signed-off-by: Feng Tang Looks good to me. Feel free to use: Reviewed-by: Petr Mladek Best Regards, Petr