From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>
Subject: [GIT PULL] timer subsystem fix
Date: Sat, 15 Nov 2025 10:13:22 +0100 [thread overview]
Message-ID: <aRhEMsGHd01Wmozp@gmail.com> (raw)
Linus,
Please pull the latest timers/urgent Git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-2025-11-15
# HEAD: e0fd4d42e27f761e9cc82801b3f183e658dc749d posix-timers: Plug potential memory leak in do_timer_create()
Fix a memory leak in the posix timer creation logic.
Thanks,
Ingo
------------------>
Eslam Khafagy (1):
posix-timers: Plug potential memory leak in do_timer_create()
kernel/time/posix-timers.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index aa3120104a51..56e17b625c72 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -475,12 +475,6 @@ static int do_timer_create(clockid_t which_clock, struct sigevent *event,
if (!kc->timer_create)
return -EOPNOTSUPP;
- new_timer = alloc_posix_timer();
- if (unlikely(!new_timer))
- return -EAGAIN;
-
- spin_lock_init(&new_timer->it_lock);
-
/* Special case for CRIU to restore timers with a given timer ID. */
if (unlikely(current->signal->timer_create_restore_ids)) {
if (copy_from_user(&req_id, created_timer_id, sizeof(req_id)))
@@ -490,6 +484,12 @@ static int do_timer_create(clockid_t which_clock, struct sigevent *event,
return -EINVAL;
}
+ new_timer = alloc_posix_timer();
+ if (unlikely(!new_timer))
+ return -EAGAIN;
+
+ spin_lock_init(&new_timer->it_lock);
+
/*
* Add the timer to the hash table. The timer is not yet valid
* after insertion, but has a unique ID allocated.
next reply other threads:[~2025-11-15 9:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 9:13 Ingo Molnar [this message]
2025-11-15 18:26 ` [GIT PULL] timer subsystem fix pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 6:39 Ingo Molnar
2026-05-17 19:28 ` pr-tracker-bot
2026-05-09 2:01 Ingo Molnar
2026-05-09 3:32 ` pr-tracker-bot
2026-04-20 7:39 Ingo Molnar
2026-04-20 23:31 ` pr-tracker-bot
2026-03-29 5:27 Ingo Molnar
2026-03-29 17:29 ` pr-tracker-bot
2026-03-15 3:30 Ingo Molnar
2026-03-15 18:47 ` pr-tracker-bot
2026-03-08 0:49 Ingo Molnar
2026-03-08 1:23 ` pr-tracker-bot
2026-01-18 10:05 Ingo Molnar
2026-01-19 13:54 ` pr-tracker-bot
2025-09-14 9:34 Ingo Molnar
2025-09-14 15:43 ` pr-tracker-bot
2025-09-07 10:35 Ingo Molnar
2025-09-07 15:32 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRhEMsGHd01Wmozp@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.