All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH 0/2] rbree: inline rb_first() and rb_last()
Date: Mon, 17 Nov 2025 02:00:10 +0800	[thread overview]
Message-ID: <aRoRKp4yDGOsZ4o0@google.com> (raw)
In-Reply-To: <20251114140646.3817319-1-edumazet@google.com>

Hi Eric,

On Fri, Nov 14, 2025 at 02:06:44PM +0000, Eric Dumazet wrote:
> Inline these two small helpers, heavily used in TCP and FQ packet scheduler,
> and in many other places.
> 
> This reduces kernel text size, and brings an 1.5 % improvement on network
> TCP stress test.

Thanks for the patch!

Just out of curiosity, do you think rb_first() and rb_last() would be
worth marking with __always_inline?

Regardless, for the series:

Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Regards,
Kuan-Wei
> 
> Eric Dumazet (2):
>   rbtree: inline rb_first()
>   rbtree: inline rb_last()
> 
>  include/linux/rbtree.h | 32 ++++++++++++++++++++++++++++++--
>  lib/rbtree.c           | 29 -----------------------------
>  2 files changed, 30 insertions(+), 31 deletions(-)
> 
> -- 
> 2.52.0.rc1.455.g30608eb744-goog
> 
> 

  parent reply	other threads:[~2025-11-16 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 14:06 [PATCH 0/2] rbree: inline rb_first() and rb_last() Eric Dumazet
2025-11-14 14:06 ` [PATCH 1/2] rbtree: inline rb_first() Eric Dumazet
2025-11-14 14:06 ` [PATCH 2/2] rbtree: inline rb_last() Eric Dumazet
2025-11-16 18:00 ` Kuan-Wei Chiu [this message]
2025-11-16 18:41   ` [PATCH 0/2] rbree: inline rb_first() and rb_last() Eric Dumazet
2025-11-17 11:35     ` Kuan-Wei Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRoRKp4yDGOsZ4o0@google.com \
    --to=visitorckw@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.