All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Waiman Long <longman@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: Add header and footer to surround warning reports
Date: Mon, 17 Nov 2025 02:41:35 +0000	[thread overview]
Message-ID: <aRqLX2F4ae7hApng@google.com> (raw)
In-Reply-To: <CAMuHMdVL=0u0-1GtVyrf_uYadNf3L9Y8a8zemzVwU1SnNV5x8A@mail.gmail.com>

On Sat, Nov 15, 2025 at 05:36:43PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
> >                 return;
> >
> >         pr_warn("\n");
> > +       pr_warn(CUT_HERE);
> >         pr_warn("======================================================\n");
> 
> I guess you can drop all lines printing a separator made of equal signs,
> as CUT_HERE already contains a graphical separator.

I'm not sure if we'd like to maintain the "backward compatibility".  I.e.,
if there are already some tools rely on the "====" to parse the report,
should we consider to preserve the equal sign separators?

Happy to receive some more feedback.

  reply	other threads:[~2025-11-17  2:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  6:27 [PATCH] lockdep: Add header and footer to surround warning reports Tzung-Bi Shih
2025-11-15 15:20 ` kernel test robot
2025-11-15 15:55 ` Waiman Long
2025-11-17  2:41   ` Tzung-Bi Shih
2025-11-15 16:36 ` Geert Uytterhoeven
2025-11-17  2:41   ` Tzung-Bi Shih [this message]
2025-11-16 13:57 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRqLX2F4ae7hApng@google.com \
    --to=tzungbi@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.