From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F648CEBF61 for ; Mon, 17 Nov 2025 12:48:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2EF510E07D; Mon, 17 Nov 2025 12:48:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="NUcPBlOq"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 750E510E07D for ; Mon, 17 Nov 2025 12:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763383702; bh=7nr5/UgGwlpc224ORaEZomQ03C0rErv8PTA2QtrZZTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NUcPBlOq4zzN9P+0BMTNT1CBE83TEBRsL/CnCTVzySLcVnAodpuRjHbtt8hBNi90b qJU+dHPbOUZJFN/dx7Udzj7ip4ATrbRCIuVzqzuUckLERfGpDeOIL0gnaIQW9kMvyR 3GLujjrLwcSUYf/EXTVfhKHRqRmIrag09fxxjAhXpAOkcOYQNH6BOblQUQMJkOh2Z1 mYkN/TrlDgRtDXyVracusAUeuL9eX2MDHccZT5J4xdlp0TtBD2vndmacm1VSjPa3aI k5fMmGEoNZBpAW3JJkzDeBFRtwuT4sAxFdNatIRTPY4DnO0Nrlc3nLhj9X6F9gBRn9 RpDcamqsDg2ag== Received: from xpredator (unknown [IPv6:2a02:2f08:eb0f:ad00:e88e:21ff:fe65:be18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mvlad) by bali.collaboradmins.com (Postfix) with ESMTPSA id B610417E0B85; Mon, 17 Nov 2025 13:48:21 +0100 (CET) Date: Mon, 17 Nov 2025 14:48:20 +0200 From: Marius Vlad To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org, dmitry.baryshkov@oss.qualcomm.com, tzimmermann@suse.de, simona.vetter@ffwll.ch, jani.nikula@linux.intel.com, ian.forbes@broadcom.com, louis.chauvet@bootlin.com, daniel.stone@collabora.com Subject: Re: [PATCH 1/4] drm: Introduce a new connector status Message-ID: References: <20251111162338.15141-1-marius.vlad@collabora.com> <20251111162338.15141-2-marius.vlad@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oYoxWeRdu1uWdM2f" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --oYoxWeRdu1uWdM2f Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ville, On Tue, Nov 11, 2025 at 08:54:59PM +0200, Ville Syrj=E4l=E4 wrote: > On Tue, Nov 11, 2025 at 06:23:35PM +0200, Marius Vlad wrote: > > Introduce a new boolean variable used to track connector's > > connect/disconnect status and it is being used on both polling and the > > HPD (Hot Plug Detect) paths. > >=20 > > A subsequent change would make use of this connector status to propagate > > per-connector udev hotplug events. > >=20 > > The connector status is set in the drm_connector_funcs.fill_modes/vkms > > ConfigFS connector's status and cleared out when firing out KMS uevents. > >=20 > > Allows user-space to receive the connector's ID, rather than having a > > generic hot-plug event for all connectors, or in the HPD path, just the > > first one found with a connection status change. > >=20 > > Signed-off-by: Marius Vlad > > --- > > drivers/gpu/drm/drm_connector.c | 1 + > > drivers/gpu/drm/drm_probe_helper.c | 17 +++++++++++++++++ > > drivers/gpu/drm/drm_sysfs.c | 1 + > > drivers/gpu/drm/vkms/vkms_configfs.c | 6 ++++++ > > include/drm/drm_connector.h | 3 +++ > > 5 files changed, 28 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_conn= ector.c > > index 272d6254ea47..3c6628ee3096 100644 > > --- a/drivers/gpu/drm/drm_connector.c > > +++ b/drivers/gpu/drm/drm_connector.c > > @@ -274,6 +274,7 @@ static int drm_connector_init_only(struct drm_devic= e *dev, > > =20 > > /* provide ddc symlink in sysfs */ > > connector->ddc =3D ddc; > > + connector->status_changed =3D false; > > =20 > > INIT_LIST_HEAD(&connector->head); > > INIT_LIST_HEAD(&connector->global_connector_list_entry); > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_p= robe_helper.c > > index 09b12c30df69..f0474368e98d 100644 > > --- a/drivers/gpu/drm/drm_probe_helper.c > > +++ b/drivers/gpu/drm/drm_probe_helper.c > > @@ -629,6 +629,8 @@ int drm_helper_probe_single_connector_modes(struct = drm_connector *connector, > > mod_delayed_work(system_wq, > > &dev->mode_config.output_poll_work, > > 0); > > + > > + connector->status_changed =3D true; >=20 > .fill_modes() gets exectued from the getconnector() ioctl which userspace > issues in response to the uevent. Not the other way around. So looks > like you have the chicken and egg the wrong way around here. =2Efill_modes() is for drm_sysfs path to simulate a hot-plug event. There's no getconnector in that case. >=20 > > } > > =20 > > /* > > @@ -732,6 +734,17 @@ EXPORT_SYMBOL(drm_helper_probe_single_connector_mo= des); > > */ > > void drm_kms_helper_hotplug_event(struct drm_device *dev) > > { > > + struct drm_connector *connector; > > + struct drm_connector_list_iter conn_iter; > > + > > + mutex_lock(&dev->mode_config.mutex); > > + drm_connector_list_iter_begin(dev, &conn_iter); > > + drm_for_each_connector_iter(connector, &conn_iter) { > > + connector->status_changed =3D false; > > + } > > + drm_connector_list_iter_end(&conn_iter); > > + mutex_unlock(&dev->mode_config.mutex); > > + > > drm_sysfs_hotplug_event(dev); > > drm_client_dev_hotplug(dev); > > } > > @@ -748,6 +761,10 @@ void drm_kms_helper_connector_hotplug_event(struct= drm_connector *connector) > > { > > struct drm_device *dev =3D connector->dev; > > =20 > > + mutex_lock(&dev->mode_config.mutex); > > + connector->status_changed =3D false; > > + mutex_unlock(&dev->mode_config.mutex); > > + > > drm_sysfs_connector_hotplug_event(connector); > > drm_client_dev_hotplug(dev); > > } > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > > index b01ffa4d6509..bd9161490116 100644 > > --- a/drivers/gpu/drm/drm_sysfs.c > > +++ b/drivers/gpu/drm/drm_sysfs.c > > @@ -199,6 +199,7 @@ static ssize_t status_store(struct device *device, > > return ret; > > =20 > > old_force =3D connector->force; > > + connector->status_changed =3D true; > > =20 > > if (sysfs_streq(buf, "detect")) > > connector->force =3D 0; > > diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkm= s/vkms_configfs.c > > index 506666e21c91..6d6dd1a2c3a6 100644 > > --- a/drivers/gpu/drm/vkms/vkms_configfs.c > > +++ b/drivers/gpu/drm/vkms/vkms_configfs.c > > @@ -537,8 +537,14 @@ static ssize_t connector_status_store(struct confi= g_item *item, > > { > > struct vkms_configfs_connector *connector; > > enum drm_connector_status status; > > + struct vkms_connector *vkms_connector; > > + struct vkms_device *vkms_dev; > > =20 > > connector =3D connector_item_to_vkms_configfs_connector(item); > > + vkms_connector =3D connector->config->connector; > > + vkms_dev =3D connector->config->config->dev; > > + scoped_guard(mutex, &vkms_dev->drm.mode_config.mutex) > > + vkms_connector->base.status_changed =3D true; > > =20 > > if (kstrtouint(page, 10, &status)) > > return -EINVAL; > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index 8f34f4b8183d..e4310df3d55c 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -2146,6 +2146,9 @@ struct drm_connector { > > /** @force: a DRM_FORCE_ state for forced mode sets */ > > enum drm_connector_force force; > > =20 > > + /** @status_changed: if the old status doesn't match current connecti= on status */ > > + bool status_changed; > > + > > /** > > * @edid_override: Override EDID set via debugfs. > > * > > --=20 > > 2.47.2 >=20 > --=20 > Ville Syrj=E4l=E4 > Intel --oYoxWeRdu1uWdM2f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEcDKHej6x6uPk3J379jQS5glH1u8FAmkbGZEACgkQ9jQS5glH 1u9G3Q//USuYYI5dajeVqzsYvmkYj0fqsZl5TSyz1QGqq+xrerUU7iiiaejgK18S btqQnY9CKvGWCwsJtz6M4aiEUfzBSbUXdiLDSb0u8LSkUWIUxD/DQ8avNSiU5o5d +XKWCCO6BKUoirSz4zMcMVnfx1viO7R3rar8lb8EZKo+jW2ShMu1FZn6paMWsQTy 6YIet2ajzLTNGLcuxJwtHt+wPGrpZukFFMfczVCdEzU7oTkpBYjiLH2MKn74sQ/A Eaj3UvRor7H8frW771scM11NaM6JxblS1azxNpV11bcOvNi6yyfhWsxF0wpnLfGO lwbGqIyvdRkAVC+Lk4z6IBEU7CaVH+d0kX2ceiWm+OYCRY7PgjXQDL6XRZT/yJWc fh4b++N8m6+EkZqxWHop/KWsVvkPMMNvw1NaGAOSbsR8ItyQePI32vktaouLct9z ZRWMvY/xLMvIukg9CwMynpbPxWkwribe7hGL+MSoveKFuMZ+WVZddfe1OdlUSdrf AwTw6IfXCGuQrMnSjt5LmcXP4uTAXqbW4FcWnF/+D2P/hrL0pyuD0YeZ5JBOF5Rd BC1T8cNDRAMYo4VhkHtkHixu6WTlNZwNtKixIu1VmZ3NYPtZcH/KsJqSQFZM6Nz3 5iutwS4K3B4LgRqiwChF9f1cig0khyp3zs6rXVmPFnkoyBvSL/E= =ypFz -----END PGP SIGNATURE----- --oYoxWeRdu1uWdM2f--