All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Vimal Agrawal <avimalin@gmail.com>
Cc: vimal.agrawal@sophos.com, linux-kernel@vger.kernel.org,
	pablo@netfilter.org, netfilter-devel@vger.kernel.org,
	anirudh.gupta@sophos.com
Subject: Re: [PATCH v3] nf_conntrack: sysctl: expose gc worker scan interval via sysctl
Date: Mon, 17 Nov 2025 15:16:51 +0100	[thread overview]
Message-ID: <aRsuU57juCvsMBKE@strlen.de> (raw)
In-Reply-To: <CALkUMdQmHAoJ8dQGi9qmwOw_MbJin1oKr3rHpH8OkdfkC0XtQA@mail.gmail.com>

Vimal Agrawal <avimalin@gmail.com> wrote:
> How about we keep only the minimum expiry time out of all (one which
> is going to expire next) and if there are listeners then we just
> schedule gc_worker to that minimum time (and do this only if there are
> ctnetlink listeners in userspace)? so that we don't delay even if
> there is 1 such low value timer expiring in the near future.
> Do you think it will cause too frequent wake ups for gc_worker?

Yes, I am worried about 1k extra wakeups/s in worst case
(we always have exactly one flow which has 1 jiffy remaining).

Plus we might have per-net workers in the future, so it could get
worse.

      reply	other threads:[~2025-11-17 14:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 13:09 [PATCH v1] nf_conntrack: sysctl: expose gc worker scan interval via sysctl avimalin
2025-04-29 13:29 ` Florian Westphal
2025-04-30  6:43   ` [PATCH v2] " avimalin
2025-04-30  7:11     ` Florian Westphal
2025-04-30  7:28       ` [PATCH v3] " avimalin
2025-04-30  7:57         ` Florian Westphal
2025-05-03  2:27           ` Vimal Agrawal
2025-05-08  5:54             ` Vimal Agrawal
2025-10-15 13:32         ` Florian Westphal
2025-11-17 13:23           ` Vimal Agrawal
2025-11-17 14:16             ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRsuU57juCvsMBKE@strlen.de \
    --to=fw@strlen.de \
    --cc=anirudh.gupta@sophos.com \
    --cc=avimalin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=vimal.agrawal@sophos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.