From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Wei Fang <wei.fang@nxp.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"eric@nelint.com" <eric@nelint.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link
Date: Tue, 18 Nov 2025 14:02:14 +0000 [thread overview]
Message-ID: <aRx8Zh-7MWeY0iJd@shell.armlinux.org.uk> (raw)
In-Reply-To: <e7222c87-3e4c-4170-993b-dbf5ba26c462@lunn.ch>
On Tue, Nov 18, 2025 at 03:00:00PM +0100, Andrew Lunn wrote:
> > > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link
> > > > configuration")
> > > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > > > Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> > >
> > > NAK. I give up.
> > >
> >
> > Sorry, could you please tell me what the reason is?
>
> I think Russell is referring to the commit message, and how you only
> quoted a little section of his explanation. There is no limit to
> commit messages, they don't need to be short. It is actually better if
> they are long. So you could use his whole explanation. And then you
> don't need the link.
Worse than that. I gave my reviewed-by, which seems to have been a waste
of time.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-18 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 10:29 [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link Wei Fang
2025-11-18 8:23 ` Russell King (Oracle)
2025-11-18 8:43 ` Wei Fang
2025-11-18 14:00 ` Andrew Lunn
2025-11-18 14:02 ` Russell King (Oracle) [this message]
2025-11-19 1:22 ` Wei Fang
2025-11-19 16:06 ` Russell King (Oracle)
2025-11-19 16:30 ` Jakub Kicinski
2025-11-19 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRx8Zh-7MWeY0iJd@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric@nelint.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.