From: John Levon <john.levon@nutanix.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org,
Thanos Makatos <thanos.makatos@nutanix.com>,
Peter Maydell <peter.maydell@linaro.org>,
Mark Cave-Ayland <mark.caveayland@nutanix.com>
Subject: Re: [PATCH v2 4/5] vfio-user: simplify vfio_user_recv_one()
Date: Tue, 18 Nov 2025 20:33:56 +0530 [thread overview]
Message-ID: <aRyK3KUe0E-bng5f@lent> (raw)
In-Reply-To: <819f4595-b323-4dcb-96c5-09c52cb09380@redhat.com>
On Tue, Nov 18, 2025 at 03:57:56PM +0100, Cédric Le Goater wrote:
> On 11/17/25 16:56, John Levon wrote:
> > This function was unnecessarily difficult to understand due to the
> > separate handling of request and reply messages. Use common code for
> > both where we can.
>
> It's still difficult to read :) Could we have feedback from Thanos or Mark ?
It is surely better though?
regards
john
next prev parent reply other threads:[~2025-11-18 15:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 15:56 [PATCH v2 0/5] vfio-user coverity fixes John Levon
2025-11-17 15:56 ` [PATCH v2 1/5] vfio-user: simplify vfio_user_process() John Levon
2025-11-18 14:15 ` Cédric Le Goater
2025-11-17 15:56 ` [PATCH v2 2/5] vfio-user: clarify partial message handling John Levon
2025-11-18 14:15 ` Cédric Le Goater
2025-11-17 15:56 ` [PATCH v2 3/5] vfio-user: refactor out header handling John Levon
2025-11-18 14:38 ` Cédric Le Goater
2025-11-17 15:56 ` [PATCH v2 4/5] vfio-user: simplify vfio_user_recv_one() John Levon
2025-11-18 14:57 ` Cédric Le Goater
2025-11-18 15:03 ` John Levon [this message]
2025-11-25 7:43 ` Cédric Le Goater
2025-11-25 17:13 ` Peter Maydell
2025-11-25 18:16 ` John Levon
2025-11-25 16:20 ` Thanos Makatos
2025-11-17 15:56 ` [PATCH v2 5/5] vfio-user: recycle msg on failure John Levon
2025-11-17 15:58 ` John Levon
2025-11-18 15:18 ` Philippe Mathieu-Daudé
2025-11-18 17:43 ` John Levon
2025-11-19 13:45 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRyK3KUe0E-bng5f@lent \
--to=john.levon@nutanix.com \
--cc=clg@redhat.com \
--cc=mark.caveayland@nutanix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.