Re: [PATCH 3/3] ebpf: Make ebpf_rss_load() return value consistent with @errp

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Nov 18, 2025 at 04:47:18PM +0100, Markus Armbruster wrote:
> ebpf_rss_load() returns false for failure without setting an Error
> when its @ctx argument already has an eBPF program loaded.  This is
> wrong.  Fortunately, it is only called @ctx has a program.  Replace
> the incorrect error check by an assertion.
> 
> The return value is now obviously reliable.  Change the caller to use
> it, because it's more concise.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  ebpf/ebpf_rss.c     | 4 +---
>  hw/net/virtio-net.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|