Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error

[Jarkko Sakkinen <jarkko@kernel.org>]

On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote:
> On Mon, 1 Dec 2025 20:18:45 +0800
> kernel test robot <lkp@intel.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 11.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from <command-line>:
> >    drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error  
> ...
> >    drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> >      456 |                 burstcnt = min(burstcnt, len - count - 1);
> 
> I hate compiler differences.
> Usually the:
> 	if (burstcnt < 0) {
> 		...
> 		goto out_err;
> 	}
> a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
> 
> I'm not sure why it doesn't here.
> 
> 	David

It is already part of PR, which I've revised already once in order to
drop one patch:

https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u

Since I don't want to end up into a cycle of iterations with this I can
at this point drop the patch, unless better suggestions are available.

I.e., I'll update PR one more time dropping this patch.

We can revisit this during rc cycles. I'll hold on for a while before
taking action in order to leave a bit window to respond. Just need to
address this quickly, that's all.

BR, Jarkko