From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C34B02F25F8 for ; Mon, 1 Dec 2025 14:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764599186; cv=none; b=Ysuxmix95nrtqKyj8JoYXVYrLkbAvI364+QClZ4wOK2mytaEaBemQksrO5CRcPWTSlf6iI1KSg1l++3wnYxgRiF/TqQFtxkJVFWniSrsuesG+ckgvCr1VKoFVDNkM54Hr+oBOSXANHcMhhFFWWNQIsZLp65jqPepgJEseIRnmUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764599186; c=relaxed/simple; bh=es7564UxwoqNq4YnDKdMAsnrw4iGgxCfmEM32gkaAc8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pFAHu1//FzLARp4xsNfV8CiISeFoNVE6WlDn4bO3lsF7n6x59PqbFs4fGiEfDdVBpTDSqTi6JkCXjbwq0lrVz4DDLTxjHjpY8ELppRjuIV21bmkY2LlPnXMGUIj/qn73/l5TVk/azR6EWpz2qYR2XUogLcBsM50+YvusVMqAepM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E0SQ8UD8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E0SQ8UD8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0432DC4CEF1; Mon, 1 Dec 2025 14:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764599186; bh=es7564UxwoqNq4YnDKdMAsnrw4iGgxCfmEM32gkaAc8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E0SQ8UD8UNF3IiyB7M9moVCQZ9yYJ+vKZgHpwY6odo1dOgospZWwQOKtQ5w33LuxM qWqDak+KAJZiiWbr2OudvVL3r3oFjvdnvpK3yMRPwG3xr1o7ZgIp/lt654u0iGfbhC wVPw2G0eoL3UCbOO+Ni0I6ZBwbMUoWpWRFjAg9/yyKI97rU8FA2wwGSODXtwYfCVhH NGL3AGDB0Tz48Xohn2G3grTv9/IkuUUcxX8hxk+oZ9MUuRdYOgGIG0ChEqr2oqRzpV mm30XXmhOvInn7ETrytotlQ7ytN4/6aV2TqBiQviPrpZYTVz/mY82RmqCsmFrvzpth PNYJwaRGsFNHg== Date: Mon, 1 Dec 2025 16:26:22 +0200 From: Jarkko Sakkinen To: David Laight Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linus Torvalds Subject: Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error Message-ID: References: <202512012040.BkoYgkkr-lkp@intel.com> <20251201124256.328f4f35@pumpkin> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124256.328f4f35@pumpkin> On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote: > On Mon, 1 Dec 2025 20:18:45 +0800 > kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a > > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t() > > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config) > > compiler: xtensa-linux-gcc (GCC) 11.5.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from : > > drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data': > > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error > ... > > drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min' > > 456 | burstcnt = min(burstcnt, len - count - 1); > > I hate compiler differences. > Usually the: > if (burstcnt < 0) { > ... > goto out_err; > } > a few lines higher is enough to make the statically_true(burstcnt >= 0) pass. > > I'm not sure why it doesn't here. > > David It is already part of PR, which I've revised already once in order to drop one patch: https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u Since I don't want to end up into a cycle of iterations with this I can at this point drop the patch, unless better suggestions are available. I.e., I'll update PR one more time dropping this patch. We can revisit this during rc cycles. I'll hold on for a while before taking action in order to leave a bit window to respond. Just need to address this quickly, that's all. BR, Jarkko