From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
Cc: andy@kernel.org, krzk@kernel.org, linus.walleij@linaro.org,
nathan@kernel.org, nsc@kernel.org, gregkh@linuxfoundation.org,
bleung@chromium.org, heikki.krogerus@linux.intel.com,
abhishekpandit@chromium.org, masahiroy@kernel.org,
legion@kernel.org, hughd@google.com,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/1] mcb: Add modpost support for processing MODULE_DEVICE_TABLE
Date: Mon, 1 Dec 2025 20:04:45 +0200 [thread overview]
Message-ID: <aS3YvQMhbmnYiZrm@smile.fi.intel.com> (raw)
In-Reply-To: <20251201160720.28580-1-dev-josejavier.rodriguez@duagon.com>
On Mon, Dec 01, 2025 at 05:07:19PM +0100, Jose Javier Rodriguez Barbarin wrote:
> During the process of update of one of the device drivers that are part of
> mcb bus (gpio-menz127.c), Krzysztof from GPIO subsystem asked me
> why I was adding new MODULE_ALIAS when I also added the same new
> information on MODULE_DEVICE_TABLE.
>
> You can find the messages here:
>
> https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/
>
> After a deeper analysis, I came across that the mcb_table_id defined inside
> MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was
> not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former
> contributors were using MODULE_ALIAS for enabling mcb to autoload the
> device drivers.
>
> My proposal with these changes is to complete the mcb bus by adding
> modpost support for processing mcb MODULE_DEVICE_TABLE.
>
> Once this patch is merged, I will send patches one by one for removing
> MODULE_ALIAS from all device drivers as they are no longer needed
> (as Andy Shevchenko suggested in v1 review).
Not sure if we need a cover letter for a single change, but yes, this
what I think the best approach and code wise it's fine to me:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
(but we still need a Fixes tag I assume).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-01 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 16:07 [PATCH v2 0/1] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Jose Javier Rodriguez Barbarin
2025-12-01 16:07 ` [PATCH v2 1/1] mcb: Add missing modpost build support Jose Javier Rodriguez Barbarin
2025-12-01 18:02 ` Andy Shevchenko
2025-12-01 18:04 ` Andy Shevchenko [this message]
2025-12-01 18:26 ` [PATCH v2 0/1] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Jose Javier Rodriguez Barbarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS3YvQMhbmnYiZrm@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abhishekpandit@chromium.org \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=dev-josejavier.rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hughd@google.com \
--cc=krzk@kernel.org \
--cc=legion@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.